From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>,
grant.likely@secretlab.ca
Subject: Re: [PATCH 5/5] TPS65911: Comparator: Add comparator driver
Date: Tue, 3 May 2011 18:28:17 +0100 [thread overview]
Message-ID: <20110503172817.GD1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <2F3D4669-91BC-400F-8A0F-D854DBB9C756@slimlogic.co.uk>
On Tue, May 03, 2011 at 11:19:07AM -0500, Jorge Eduardo Candelaria wrote:
> +/* Comparator 1 voltage selection table in milivolts */
> +static const u16 COMP1_VSEL_TABLE[] = {
> + 0, 2500, 2500, 2500, 2500, 2550, 2600, 2650,
> + 2700, 2750, 2800, 2850, 2900, 2950, 3000, 3050,
> + 3100, 3150, 3200, 3250, 3300, 3350, 3400, 3450,
> + 3500,
> +};
> +
> +/* Comparator 2 voltage selection table in milivolts */
> +static const u16 COMP2_VSEL_TABLE[] = {
> + 0, 2500, 2500, 2500, 2500, 2550, 2600, 2650,
> + 2700, 2750, 2800, 2850, 2900, 2950, 3000, 3050,
> + 3100, 3150, 3200, 3250, 3300, 3350, 3400, 3450,
> + 3500,
> +};
These look remarkably similar...
> +static DEVICE_ATTR(comp1_threshold, S_IRUGO, comp_threshold_show, NULL);
> +static DEVICE_ATTR(comp2_threshold, S_IRUGO, comp_threshold_show, NULL);
We should really have a proper API for this, it's a pretty common
feature on devices with an auxilliary ADC of some kind.
prev parent reply other threads:[~2011-05-03 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 16:19 [PATCH 5/5] TPS65911: Comparator: Add comparator driver Jorge Eduardo Candelaria
2011-05-03 17:28 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503172817.GD1762@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox