From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>,
grant.likely@secretlab.ca
Subject: Re: [PATCH 3/5] TPS65911: Add new irq definitions
Date: Tue, 3 May 2011 18:30:12 +0100 [thread overview]
Message-ID: <20110503173011.GE1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <63D42968-AD20-47D2-9AAB-2878EBDBA302@slimlogic.co.uk>
On Tue, May 03, 2011 at 11:18:56AM -0500, Jorge Eduardo Candelaria wrote:
> + if (tps65910_chip_id(tps65910) == TPS65911) {
> + tps65910->read(tps65910, TPS65910_INT_STS3, 1, ®);
> + irq_sts |= reg << 16;
> + }
switch statements feel better for future proofing - if your hardware
guys do another design derived from this base you'll need to add another
case in here.
prev parent reply other threads:[~2011-05-03 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 16:18 [PATCH 3/5] TPS65911: Add new irq definitions Jorge Eduardo Candelaria
2011-05-03 17:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503173011.GE1762@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox