public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Peter Foley <pefoley2@verizon.net>
Cc: Greg KH <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, hjanssen@microsoft.com,
	haiyangz@microsoft.com
Subject: Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error
Date: Tue, 3 May 2011 10:33:09 -0700	[thread overview]
Message-ID: <20110503173309.GA25014@kroah.com> (raw)
In-Reply-To: <4DB61786.2030307@verizon.net>

On Mon, Apr 25, 2011 at 08:53:26PM -0400, Peter Foley wrote:
> On 4/25/2011 8:00 PM, Greg KH wrote:
> > On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote:
> >> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error.
> > 
> > What is the build error?
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> When CONFIG_HYPERV_UTILS=y and CONFIG_NLS=n
> the build fails with this error:
> 
>  Building modules, stage 2.
>   MODPOST 3 modules
> ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined!
> make[3]: *** [__modpost] Error 1
> make[2]: *** [modules] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Kernel: arch/x86/boot/bzImage is ready  (#2)
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2

Ah, ok, we need this for that function, that's what I wanted to know,
I'll put it in the changelog entry.  Please do that the next time.

thanks,

greg k-h

  reply	other threads:[~2011-05-03 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 23:52 [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error Peter Foley
2011-04-26  0:00 ` Greg KH
2011-04-26  0:53   ` Peter Foley
2011-05-03 17:33     ` Greg KH [this message]
2011-05-03 17:57 ` Greg KH
2011-05-03 18:11   ` Peter Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110503173309.GA25014@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=haiyangz@microsoft.com \
    --cc=hjanssen@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pefoley2@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox