From: Borislav Petkov <bp@amd64.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@amd64.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
EDAC devel <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] x86, mce: Have MCE persistent event off by default for now
Date: Tue, 3 May 2011 21:52:00 +0200 [thread overview]
Message-ID: <20110503195200.GA23243@aftab> (raw)
In-Reply-To: <987664A83D2D224EAE907B061CE93D5301C53670E0@orsmsx505.amr.corp.intel.com>
On Tue, May 03, 2011 at 01:17:50PM -0400, Luck, Tony wrote:
> > Ok, the problem I see with it is that people without a RAS daemon
> > running will have the mechanism collecting MCEs in the background, using
> > up resources (4 pages per CPU is the buffer) and not doing anything (in
> > the best case that is, when we're not broken otherwise).
>
> Can the kernel detect whether anyone is listening to the
> persistent MCE event? If so, then the kernel could printk()
> something to let the user with no RAS daemon (or a dead
> daemon) that stuff is happening that they might like to
> know about.
Right, so I have a primitive way to do that when you enable ras over the
command line, i.e. boot with "ras=on." But that doesn't help in cases
where the daemon dies for some reason.
Maybe the decoding path should look at whether the event descriptor is
still mmapped or whether the event is enabled; let me think about it a
bit longer, good point btw!
> Probably make some sense to delay such a message (so that in
> the boot case we give the daemon a chance to get started before
> complaining that it hasn't shown up for work).
Yep, that and also I need to address the case for catching earlybird
MCEs, when perf hasn't been initialized yet. I'm thinking we could
reuse the mcelog buffer and feed those into the RAS daemon after init.
Something like that.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-05-03 19:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 17:34 [PATCH 0/4] RAS daemon: kernel part Borislav Petkov
2011-05-02 17:34 ` [PATCH 1/4] perf: Start the restructuring Borislav Petkov
2011-05-02 17:34 ` [PATCH 2/4] perf: Add persistent event facilities Borislav Petkov
2011-05-03 6:40 ` Ingo Molnar
2011-05-03 6:48 ` Ingo Molnar
2011-05-03 7:12 ` Borislav Petkov
2011-05-03 8:22 ` Ingo Molnar
2011-05-03 12:51 ` [GIT PULL] Rename perf_event.c Borislav Petkov
2011-05-03 12:59 ` [PATCH 2/4] perf: Add persistent event facilities Frederic Weisbecker
2011-05-03 13:30 ` Borislav Petkov
2011-05-03 14:26 ` Borislav Petkov
2011-05-02 17:34 ` [PATCH 3/4] x86, mce: Add persistent MCE event Borislav Petkov
2011-05-03 6:44 ` Ingo Molnar
2011-05-03 7:18 ` Borislav Petkov
2011-05-03 8:27 ` Ingo Molnar
2011-05-03 15:14 ` Joe Perches
2011-05-03 15:22 ` Borislav Petkov
2011-05-03 15:32 ` Joe Perches
2011-05-03 15:34 ` Steven Rostedt
2011-05-03 15:42 ` Borislav Petkov
2011-05-02 17:34 ` [PATCH 4/4] x86, mce: Have MCE persistent event off by default for now Borislav Petkov
2011-05-03 6:45 ` Ingo Molnar
2011-05-03 7:23 ` Borislav Petkov
2011-05-03 8:17 ` Ingo Molnar
2011-05-03 17:17 ` Luck, Tony
2011-05-03 19:52 ` Borislav Petkov [this message]
2011-05-03 19:56 ` Ingo Molnar
2011-05-04 6:58 ` Ingo Molnar
2011-05-04 21:40 ` Luck, Tony
2011-05-05 1:34 ` Arnaldo Carvalho de Melo
2011-05-05 6:39 ` Ingo Molnar
2011-05-05 7:17 ` Borislav Petkov
2011-05-05 7:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503195200.GA23243@aftab \
--to=bp@amd64.org \
--cc=acme@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox