From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988Ab1ECXIT (ORCPT ); Tue, 3 May 2011 19:08:19 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:39979 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753918Ab1ECXIS (ORCPT ); Tue, 3 May 2011 19:08:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=aoT/emdKqp+V6tKh6HVY86DFWHQirWiAZYZcZ8DFXxT4KpgtF4V9E3NKVdVchzlbym mGpPMezlxdLNAB78ywOQrI0p/CyoiOnZGGebUKvQB5LWhYCta1Po/33j55kNAGBhRCSo QpnOfsnlm7hIp+bAQD9IidqirIQeG3HMd/ULM= Date: Wed, 4 May 2011 01:08:14 +0200 From: Frederic Weisbecker To: Steven Rostedt Cc: Vaibhav Nagarnaik , Ingo Molnar , Michael Rubin , David Sharp , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] tracing: Don't call wakeup() when committing the event Message-ID: <20110503230812.GF2678@nowhere> References: <1304456616-30281-1-git-send-email-vnagarnaik@google.com> <20110503214142.GC2678@nowhere> <20110503220948.GE2678@nowhere> <1304462852.25414.2417.camel@gandalf.stny.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304462852.25414.2417.camel@gandalf.stny.rr.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2011 at 06:47:32PM -0400, Steven Rostedt wrote: > On Wed, 2011-05-04 at 00:09 +0200, Frederic Weisbecker wrote: > > > I wonder if we should have a lite version of wake_up() that checks > > if the list of waiters is empty before locking the queue. > > After all we don't care much about tight races for tracing. > > Since tracing is a special case here, we probably could get away to just > do it ourselves. That is, have our own flag that determines if we should > wakeup or not. Yep, agreed.