From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030Ab1EDJ3w (ORCPT ); Wed, 4 May 2011 05:29:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:11510 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752478Ab1EDJ2h (ORCPT ); Wed, 4 May 2011 05:28:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,313,1301900400"; d="scan'208";a="687915504" Message-Id: <20110504091909.272180199@intel.com> User-Agent: quilt/0.48-1 Date: Wed, 04 May 2011 17:17:08 +0800 From: Wu Fengguang To: Andrew Morton cc: Jan Kara , Peter Zijlstra , Wu Fengguang cc: Dave Chinner Cc: LKML cc: Subject: [PATCH 1/6] writeback: add bdi_dirty_limit() kernel-doc References: <20110504091707.910929441@intel.com> Content-Disposition: inline; filename=writeback-task_dirty_limit-comment.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clarify the bdi_dirty_limit() comment. Acked-by: Peter Zijlstra Acked-by: Jan Kara Signed-off-by: Wu Fengguang --- mm/page-writeback.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) --- linux-next.orig/mm/page-writeback.c 2011-04-19 10:18:16.000000000 +0800 +++ linux-next/mm/page-writeback.c 2011-04-19 10:18:32.000000000 +0800 @@ -437,10 +437,17 @@ void global_dirty_limits(unsigned long * *pdirty = dirty; } -/* +/** * bdi_dirty_limit - @bdi's share of dirty throttling threshold + * @bdi: the backing_dev_info to query + * @dirty: global dirty limit in pages + * + * Returns @bdi's dirty limit in pages. The term "dirty" in the context of + * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. + * And the "limit" in the name is not seriously taken as hard limit in + * balance_dirty_pages(). * - * Allocate high/low dirty limits to fast/slow devices, in order to prevent + * It allocates high/low dirty limits to fast/slow devices, in order to prevent * - starving fast devices * - piling up dirty pages (that will take long time to sync) on slow devices *