From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596Ab1EDLFE (ORCPT ); Wed, 4 May 2011 07:05:04 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55719 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699Ab1EDLFD (ORCPT ); Wed, 4 May 2011 07:05:03 -0400 Date: Wed, 4 May 2011 07:04:32 -0400 From: Christoph Hellwig To: Wu Fengguang Cc: Andrew Morton , Jan Kara , Mel Gorman , Mel Gorman , Dave Chinner , Itaru Kitayama , Minchan Kim , Linux Memory Management List , linux-fsdevel@vger.kernel.org, LKML Subject: Re: [PATCH 1/6] writeback: pass writeback_control down to move_expired_inodes() Message-ID: <20110504110430.GA4646@infradead.org> References: <20110420080336.441157866@intel.com> <20110420080917.759855316@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110420080917.759855316@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2011 at 04:03:37PM +0800, Wu Fengguang wrote: > No behavior change. This will add debug visibility to the code, for > example, to dump the wbc contents when kprobing queue_io(). I don't think it's a good idea. The writeback_control should move back to just controlling per-inode writeback and not be passed to more routines dealing with high-level writeback.