From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org, avi@redhat.com,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] rcu: provide rcu_virt_note_context_switch() function.
Date: Wed, 4 May 2011 09:35:42 -0700 [thread overview]
Message-ID: <20110504163542.GA2641@linux.vnet.ibm.com> (raw)
In-Reply-To: <1304515864-17105-2-git-send-email-gleb@redhat.com>
On Wed, May 04, 2011 at 04:31:03PM +0300, Gleb Natapov wrote:
> Provide rcu_virt_note_context_switch() for vitalization use to note
> quiescent state during guest entry.
Very good, queued on -rcu.
Unless you tell me otherwise, I will assume that you want to carry the
patch modifying KVM to use this.
Thanx, Paul
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
> include/linux/rcutiny.h | 8 ++++++++
> include/linux/rcutree.h | 10 ++++++++++
> kernel/rcutree.c | 1 +
> 3 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
> index 30ebd7c..52b3e02 100644
> --- a/include/linux/rcutiny.h
> +++ b/include/linux/rcutiny.h
> @@ -100,6 +100,14 @@ static inline void rcu_note_context_switch(int cpu)
> }
>
> /*
> + * Take advantage of the fact that there is only one CPU, which
> + * allows us to ignore virtualization-based context switches.
> + */
> +static inline void rcu_virt_note_context_switch(int cpu)
> +{
> +}
> +
> +/*
> * Return the number of grace periods.
> */
> static inline long rcu_batches_completed(void)
> diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h
> index 3a93348..b2a906e 100644
> --- a/include/linux/rcutree.h
> +++ b/include/linux/rcutree.h
> @@ -35,6 +35,16 @@ extern void rcu_note_context_switch(int cpu);
> extern int rcu_needs_cpu(int cpu);
> extern void rcu_cpu_stall_reset(void);
>
> +/*
> + * Note a virtualization-based context switch. This is simply a
> + * wrapper around rcu_note_context_switch(), which allows TINY_RCU
> + * to save a few bytes.
> + */
> +static inline void rcu_virt_note_context_switch(int cpu)
> +{
> + rcu_note_context_switch(cpu);
> +}
> +
> #ifdef CONFIG_TREE_PREEMPT_RCU
>
> extern void exit_rcu(void);
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index dd4aea8..0837d63 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -124,6 +124,7 @@ void rcu_note_context_switch(int cpu)
> rcu_sched_qs(cpu);
> rcu_preempt_note_context_switch(cpu);
> }
> +EXPORT_SYMBOL_GPL(rcu_note_context_switch);
>
> #ifdef CONFIG_NO_HZ
> DEFINE_PER_CPU(struct rcu_dynticks, rcu_dynticks) = {
> --
> 1.7.4.4
>
next prev parent reply other threads:[~2011-05-04 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 13:31 [PATCH 0/2] make kvm guest mode to be rcu quiescent state Gleb Natapov
2011-05-04 13:31 ` [PATCH 1/2] rcu: provide rcu_virt_note_context_switch() function Gleb Natapov
2011-05-04 16:35 ` Paul E. McKenney [this message]
2011-05-09 8:51 ` Avi Kivity
2011-05-09 12:16 ` Paul E. McKenney
2011-05-04 13:31 ` [PATCH 2/2] KVM: make guest mode entry to be rcu quiescent state Gleb Natapov
2011-05-11 9:57 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504163542.GA2641@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox