From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069Ab1EEMlX (ORCPT ); Thu, 5 May 2011 08:41:23 -0400 Received: from verein.lst.de ([213.95.11.211]:37152 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719Ab1EEMlW (ORCPT ); Thu, 5 May 2011 08:41:22 -0400 Date: Thu, 5 May 2011 14:41:22 +0200 From: Christoph Hellwig To: Wu Fengguang Cc: Jan Kara , Andrew Morton , Dave Chinner , Christoph Hellwig , LKML , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH 3/3] writeback: avoid extra sync work at enqueue time Message-ID: <20110505124122.GA24009@lst.de> References: <20110502031750.135798606@intel.com> <20110502033035.789279347@intel.com> <20110504212427.GI6968@quack.suse.cz> <20110505122732.GC1294@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110505122732.GC1294@localhost> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2011 at 08:27:32PM +0800, Wu Fengguang wrote: > - wbc.wb_start = jiffies; /* livelock avoidance */ > + oldest_jif = jiffies; > + wbc.older_than_this = &oldest_jif; Can't you kill the oldest_jif variable now?