From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mcree@orcon.net.nz, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, mattst88@gmail.com, rth@twiddle.net,
ink@jurassic.park.msu.ru
Subject: Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm
Date: Fri, 6 May 2011 09:49:25 -0400 [thread overview]
Message-ID: <20110506134925.GB5500@dumpdata.com> (raw)
In-Reply-To: <20110506212708I.fujita.tomonori@lab.ntt.co.jp>
On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote:
> On Wed, 4 May 2011 20:13:37 +1200
> Michael Cree <mcree@orcon.net.nz> wrote:
>
> > The radeon drm code now relies on DMA_ERROR_CODE. This defines
> > it in alpha dma-mapping header to at least enable me to compile
> > radeon drm/kms into kernel.
> >
> > Signed-off-by: Michael Cree <mcree@orcon.net.nz>
> > ---
> > arch/alpha/include/asm/dma-mapping.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
>
> This isn't correct. The drivers should not use DMA_ERROR_CODE directly
> (some architecture specific drivers use it though). Fix rademon
> drm/kms instead.
What would be a proper value for non-existent bus addresses? As in the value
had not been set? 0?
next prev parent reply other threads:[~2011-05-06 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 8:13 [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm Michael Cree
2011-05-04 21:59 ` Matt Turner
2011-05-06 12:43 ` FUJITA Tomonori
2011-05-06 12:30 ` FUJITA Tomonori
2011-05-06 13:49 ` Konrad Rzeszutek Wilk [this message]
2011-05-07 0:05 ` FUJITA Tomonori
2011-05-07 3:08 ` Konrad Rzeszutek Wilk
2011-05-07 23:21 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506134925.GB5500@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).