* [PATCH]mm/page_alloc.c: no need del from lru
@ 2011-05-06 15:01 Figo.zhang
2011-05-06 18:06 ` Andrea Arcangeli
0 siblings, 1 reply; 2+ messages in thread
From: Figo.zhang @ 2011-05-06 15:01 UTC (permalink / raw)
To: lkml, linux-mm@kvack.org, mel
Cc: kamezawa.hiroyu, Minchan Kim, Andrew Morton, aarcange
split_free_page() the page is still free page, it is no need del from lru.
Signed-off-by: Figo.zhang <figo1802@gmail.com>
---
mm/page_alloc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9f8a97b..55d8810 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1261,7 +1261,6 @@ int split_free_page(struct page *page)
return 0;
/* Remove page from free list */
- list_del(&page->lru);
zone->free_area[order].nr_free--;
rmv_page_order(page);
__mod_zone_page_state(zone, NR_FREE_PAGES, -(1UL << order));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]mm/page_alloc.c: no need del from lru
2011-05-06 15:01 [PATCH]mm/page_alloc.c: no need del from lru Figo.zhang
@ 2011-05-06 18:06 ` Andrea Arcangeli
0 siblings, 0 replies; 2+ messages in thread
From: Andrea Arcangeli @ 2011-05-06 18:06 UTC (permalink / raw)
To: Figo.zhang
Cc: lkml, linux-mm@kvack.org, mel, kamezawa.hiroyu, Minchan Kim,
Andrew Morton
Hello,
On Fri, May 06, 2011 at 11:01:21PM +0800, Figo.zhang wrote:
>
> split_free_page() the page is still free page, it is no need del from lru.
This is in the buddy freelist, see the other list_add in
page_alloc.c. It's not the lru as in release_pages. I see little
chance that if this was wrong it could go unnoticed so long without
major mm corruption reported. Removing it also should result in heavy
mm corruption.
Thanks,
Andrea
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-06 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-06 15:01 [PATCH]mm/page_alloc.c: no need del from lru Figo.zhang
2011-05-06 18:06 ` Andrea Arcangeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox