From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: <akpm@linux-foundation.org>, <mingo@redhat.com>,
<tglx@linutronix.de>, <hpa@zytor.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<allen.kao@atheros.com>, <roman.gezikov@atheros.com>,
<joonas.viskari@atheros.com>
Subject: Re: [RFC 1/2] misc: add Atheros ar1520 GPS support
Date: Fri, 6 May 2011 23:26:38 +0100 [thread overview]
Message-ID: <20110506232638.72e8900a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1304719780-27347-2-git-send-email-lrodriguez@atheros.com>
Last time this driver came up the answer was that the userspace was
proprietary and this was in fact part of a mixed user/kernel driver which
seemed to raise all sorts of interesting questions.
This was NAKked before for that reason so why the resubmit. Kernel policy
is clear enough ?
> + * You need a userspace application to cooperate with this driver. It and
> + * more information about this driver can be obtained here:
> + *
> + * http://wireless.kernel.org/en/users/Drivers/ar5120
Which says:
Userspace application
This driver requires a userspace application which will interact with the
driver via ioctl. More information on this to be posted later.
So NAK
Let's see an open userspace and then this driver can be submitted
+ time =
wait_event_interruptible_timeout(ar1520_data->wait_irq,
+
ar1520_data->irq_rx, +
msecs_to_jiffies(3142));
Why 3142 ?
Come to think of it why not fixes the races while you are it.
Alan
next prev parent reply other threads:[~2011-05-06 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 22:09 [RFC 0/2] x86: Add support for Atheros AR1520 GPS devices Luis R. Rodriguez
2011-05-06 22:09 ` [RFC 1/2] misc: add Atheros ar1520 GPS support Luis R. Rodriguez
2011-05-06 22:15 ` Randy Dunlap
2011-05-06 22:26 ` Alan Cox [this message]
2011-05-06 23:31 ` Luis R. Rodriguez
2011-05-06 22:09 ` [RFC 2/2] x86: add Atheros ar1520 platform support for mrst Luis R. Rodriguez
2011-05-06 22:28 ` Alan Cox
2011-05-06 23:27 ` Luis R. Rodriguez
2011-05-07 0:38 ` [RFC 0/2] x86: Add support for Atheros AR1520 GPS devices Greg KH
2011-05-07 4:32 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506232638.72e8900a@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=allen.kao@atheros.com \
--cc=hpa@zytor.com \
--cc=joonas.viskari@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mingo@redhat.com \
--cc=roman.gezikov@atheros.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox