From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stefan Hellermann <stefan@the2masters.de>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH] mm: Use alloc_bootmem_node_nopanic on really needed path
Date: Sat, 7 May 2011 10:22:57 +0200 [thread overview]
Message-ID: <20110507082257.GD25065@elte.hu> (raw)
In-Reply-To: <4DC47AA6.3080302@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> On 05/06/2011 03:39 PM, Andrew Morton wrote:
> > On Fri, 06 May 2011 15:29:41 -0700
> > Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> Stefan found nobootmem does not work on his system that only have 8M ram.
> >
> > What does "does not work" mean? From the patch, it appears that the
> > machine paniced?
>
> yes, early panic.
Why the heck did you not share this information in the original changelog
itself? Do you think maintainers enjoy having to waste time asking you again
and again to clarify your changelogs?
Changelogs need specificity. "does not work" is 10 times worse than "we saw an
early crash" or "the system booted up with only 10% of the physical RAM
visible". There are many degrees of "does not work".
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-07 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 20:02 early crash on ancient tablet related to no-bootmem Stefan Hellermann
2011-05-05 21:57 ` Stefan Hellermann
2011-05-05 22:06 ` Yinghai Lu
2011-05-05 22:46 ` Stefan Hellermann
2011-05-06 6:30 ` Yinghai Lu
2011-05-06 8:52 ` Stefan Hellermann
2011-05-06 22:29 ` PATCH] mm: Use alloc_bootmem_node_nopanic on really needed path Yinghai Lu
2011-05-06 22:39 ` Andrew Morton
2011-05-06 22:48 ` Yinghai Lu
2011-05-07 8:22 ` Ingo Molnar [this message]
2011-05-08 18:10 ` [PATCH -v2] " Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110507082257.GD25065@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@the2masters.de \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox