From: Emil Langrock <emil.langrock@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>
Subject: checkpatch "unclean" patches
Date: Sun, 8 May 2011 09:55:26 +0200 [thread overview]
Message-ID: <201105080955.27160.emil.langrock@gmx.de> (raw)
Hi,
I wanted to send some patches, but checkpatch always tells me that they arent
clean and that I should fix them... but I am sure that the checkpatch.pl is
wrong.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ERROR: need consistent spacing around '*' (ctx:WxV)
#70: FILE: abc.h:70:
+ struct xyz __rcu *bar;
^
CHECK: spinlock_t definition without comment
#92: FILE: abc.h:92:
+ spinlock_t foo; /* protects: bar, foobar, barfoo, kaazaa, flupflup, fafafa,
total: 1 errors, 0 warnings, 1 checks, 1337 lines checked
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I am quite sure that the spacing should not be "struct xyz __rcu * bar" and
that the thing behind "spinlock_t foo;" is a comment.
Should I fix my patches or should checkpatch.pl be fixed?
--
Emil Langrock
next reply other threads:[~2011-05-08 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 7:55 Emil Langrock [this message]
2011-05-08 14:45 ` checkpatch "unclean" patches Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105080955.27160.emil.langrock@gmx.de \
--to=emil.langrock@gmx.de \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox