public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Greg KH <greg@kroah.com>
Cc: EDAC devel <linux-edac@vger.kernel.org>, X86-ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>
Subject: Re: [PATCH 3/4] EDAC, MCE, AMD: Add hw_inject and cpu sysfs attrs
Date: Sun, 8 May 2011 20:49:11 +0200	[thread overview]
Message-ID: <20110508184911.GA511@aftab> (raw)
In-Reply-To: <20110508164054.GA4199@kroah.com>

On Sun, May 08, 2011 at 12:40:54PM -0400, Greg KH wrote:
> On Thu, May 05, 2011 at 06:49:35PM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@amd.com>
> > 
> > Add sysfs handlers for the 'hw_inject' and 'cpu' attrs.
> 
> You forgot to add the proper Documentation/ABI/ files for these new
> sysfs files.  Please do that.

Yeah, so those sprang up as a testing module and the final goal is to
have all injection done through perf events but it could also be prudent
to keep those as a fallback alternative.

I'm thinking something like
Documentation/ABI/testing/sysfs-devices-system-edac but looking
at Documentation/ABI/README and reading the "testing/" category
description, I don't think it applies to those interfaces just yet for
the simple reason that they're still changing and I wouldn't want to
cast them in stone now.

Can we add them to a "unstable" category instead or maybe delay making
the ABI description for now?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2011-05-08 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 16:49 [PATCH 0/4] x86, MCE, AMD: Hardware MCE injection Borislav Petkov
2011-05-05 16:49 ` [PATCH 1/4] x86, MCE: Add a HW injection flag Borislav Petkov
2011-05-05 16:49 ` [PATCH 2/4] EDAC, MCE, AMD: Add function to enable direct write to MCE MSRs Borislav Petkov
2011-05-05 16:49 ` [PATCH 3/4] EDAC, MCE, AMD: Add hw_inject and cpu sysfs attrs Borislav Petkov
2011-05-08 16:40   ` Greg KH
2011-05-08 18:49     ` Borislav Petkov [this message]
2011-05-08 19:18       ` Greg KH
2011-05-08 19:43         ` Borislav Petkov
2011-05-05 16:49 ` [PATCH 4/4] EDAC, MCE, AMD: Add an injector function Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110508184911.GA511@aftab \
    --to=bp@amd64.org \
    --cc=Borislav.Petkov@amd.com \
    --cc=greg@kroah.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox