Re: [PATCH 3/4] EDAC, MCE, AMD: Add hw_inject and cpu sysfs attrs

[Greg KH <greg@kroah.com>]

On Sun, May 08, 2011 at 08:49:11PM +0200, Borislav Petkov wrote:
> On Sun, May 08, 2011 at 12:40:54PM -0400, Greg KH wrote:
> > On Thu, May 05, 2011 at 06:49:35PM +0200, Borislav Petkov wrote:
> > > From: Borislav Petkov <borislav.petkov@amd.com>
> > > 
> > > Add sysfs handlers for the 'hw_inject' and 'cpu' attrs.
> > 
> > You forgot to add the proper Documentation/ABI/ files for these new
> > sysfs files.  Please do that.
> 
> Yeah, so those sprang up as a testing module and the final goal is to
> have all injection done through perf events but it could also be prudent
> to keep those as a fallback alternative.
> 
> I'm thinking something like
> Documentation/ABI/testing/sysfs-devices-system-edac but looking
> at Documentation/ABI/README and reading the "testing/" category
> description, I don't think it applies to those interfaces just yet for
> the simple reason that they're still changing and I wouldn't want to
> cast them in stone now.
> 
> Can we add them to a "unstable" category instead or maybe delay making
> the ABI description for now?

No.  If you add sysfs files to the kernel, you had better be sure that
they are correct and are what you want to be doing.  Otherwise, don't
add them.

As you really want to do this through perf, just do it through perf.
Please don't create a user/kernel api that you are not going to want to
use in the end.

thanks,

greg k-h