From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Lutomirski <luto@mit.edu>
Cc: linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC] Controlling the ThinkPad battery charger
Date: Mon, 9 May 2011 14:56:12 +0100 [thread overview]
Message-ID: <20110509135612.GA1873@srcf.ucam.org> (raw)
In-Reply-To: <BANLkTinWna2sDDjbNC5xyGX3ELROs=Wd0w@mail.gmail.com>
On Sun, May 08, 2011 at 08:35:32AM -0400, Andrew Lutomirski wrote:
> I like option 2 better, since it means that a userspace tool (like
> GNOME) could learn how to operate a battery charge controller once and
> then other laptops and devices could reuse the same interface. The
> problem is that the ACPI battery driver can't see the charge control.
> So either it would need a hook to allow per-vendor control like this
> or the power_supply class would need to recognize separate charge
> controllers.
I agree that this is preferable. One option would be to just use smapi
and provide a hook to detach the ACPI driver, but that would potentially
mean a certain amount of code duplication.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-05-09 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 12:35 [RFC] Controlling the ThinkPad battery charger Andrew Lutomirski
2011-05-09 13:56 ` Matthew Garrett [this message]
2011-05-09 14:45 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2011-05-09 15:10 ` Andrew Lutomirski
2011-05-09 15:29 ` Henrique de Moraes Holschuh
2011-05-09 15:47 ` Andrew Lutomirski
2011-05-10 18:43 ` Pavel Machek
2011-05-10 19:57 ` Henrique de Moraes Holschuh
2011-05-10 20:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509135612.GA1873@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).