From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751146Ab1EJFYa (ORCPT ); Tue, 10 May 2011 01:24:30 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:54259 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775Ab1EJFY3 (ORCPT ); Tue, 10 May 2011 01:24:29 -0400 Date: Tue, 10 May 2011 01:24:25 -0400 From: Christoph Hellwig To: KY Srinivasan Cc: Christoph Hellwig , Greg KH , "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" Subject: Re: various vmbus review comments Message-ID: <20110510052425.GA31087@infradead.org> References: <20110503204641.GA11132@kroah.com> <6E21E5352C11B742B20C142EB499E0481DFCFA@TK5EX14MBXC124.redmond.corp.microsoft.com> <20110504163228.GA19754@kroah.com> <6E21E5352C11B742B20C142EB499E0481E0694@TK5EX14MBXC124.redmond.corp.microsoft.com> <20110509143352.GB29635@infradead.org> <6E21E5352C11B742B20C142EB499E0481E95C6@TK5EX14MBXC128.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6E21E5352C11B742B20C142EB499E0481E95C6@TK5EX14MBXC128.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2011 at 02:56:52PM +0000, KY Srinivasan wrote: > I will address this. Greg had a concern about module reference counting > and looking at the current code, it did not appear to be an issue. The > change you are suggesting will not affect the vmbus core which is what I want > to focus on. I will however, fix this issue in the current round of patches I will > send out this week. It very clearly affects the interface between the core and the functional drivers. Trying to submit the core without making sure the interface is exports works properly is not an overly good idea.