public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: eranian@gmail.com
Cc: Vince Weaver <vweaver1@eecs.utk.edu>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <ak@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	eranian@google.com, Arun Sharma <asharma@fb.com>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>
Subject: Re: re-enable Nehalem raw Offcore-Events support
Date: Tue, 10 May 2011 11:35:38 +0200	[thread overview]
Message-ID: <20110510093538.GA2569@elte.hu> (raw)
In-Reply-To: <BANLkTinWxugxrx=7+wJGgoXvT3KGAz28Pg@mail.gmail.com>


* stephane eranian <eranian@googlemail.com> wrote:

> > Thirdly, and this is my most fundamental objection, i also object to the 
> > timing of this offcore raw access ABI, because past experience is that we 
> > *really* do not want to allow raw PMU details without *first* having 
> > generic abstractions and generic events first.
> 
> I am not opposed to generic events. [...]

Ok - and that's the most important point really.

> [...] But I don't think they're the ultimate solution to all your performance 
> problems: the crystal ball you're trying to sell.

I do not claim that and i'm not selling a crystal ball either.

I just see that 90%+ of our users use generic events (most in fact just use 
whatever comes as a default, which is cycles) and only a tiny niche uses raw 
events. I'm responding to that demand.

[ We saw that with Oprofile already: only an exceedingly small minority *ever* 
  made use of any event but the default Oprofile came with.

  So even with our current generalizations we have more than the typical 
  developer would use for profiling and we try to not define everything and the 
  kitchen sink but respond to demand in a common sense way as we see it. ]

And note that i have no problems with and no prejudices against crazy niches 
(-rt, anyone?), as long as they *know* that they are crazy and as long as they 
help the advancement of the common case!

Really, as a Linux kernel maintainer i'm very easily corrupted by niches: if 
you want me to care about your niche you only need to bribe me with 
improvements to the more common case! :-)

Note that time is running out to get the offcore bits activated even in 
v2.6.40: we are at -rc7 and the merge window is getting closer.

So if you guys care about this code please have a look at Peter's patch and 
help test/finish it (or provide a detailed and convincing technical review of 
his patch to prove why his approach to provide node level events is impossible 
to meet).

Arguing in this thread some more wont help get the code changed i'm afraid!

Thanks,

	Ingo

  reply	other threads:[~2011-05-10  9:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 15:04 re-enable Nehalem raw Offcore-Events support Vince Weaver
2011-04-29 15:27 ` Andi Kleen
2011-04-29 16:49   ` Ingo Molnar
2011-04-29 16:42 ` Ingo Molnar
2011-04-29 18:01   ` Vince Weaver
2011-04-29 18:57     ` Ingo Molnar
2011-04-30  2:17       ` Vince Weaver
2011-04-30  7:14         ` Pekka Enberg
2011-04-30 20:47           ` Vince Weaver
2011-05-01 18:31             ` Ingo Molnar
2011-04-30  8:11         ` Borislav Petkov
2011-04-30 21:03           ` Vince Weaver
2011-05-09 11:01       ` stephane eranian
2011-05-10  9:35         ` Ingo Molnar [this message]
2011-04-29 22:16   ` Borislav Petkov
2011-04-30  1:49     ` Vince Weaver
2011-04-30  1:53   ` Vince Weaver
2011-04-30 20:58     ` Vince Weaver
2011-04-30 21:09       ` Alan Cox
2011-04-29 17:17 ` Pekka Enberg
2011-04-29 17:25   ` Andi Kleen
2011-04-29 17:37     ` Pekka Enberg
2011-04-29 17:46       ` Vince Weaver
2011-04-29 17:59         ` Pekka Enberg
2011-04-29 17:42     ` Thomas Gleixner
2011-04-30 20:06       ` Corey Ashford
2011-05-01  4:45         ` Andi Kleen
2011-05-01 18:00           ` Ingo Molnar
2011-05-01 17:55         ` Ingo Molnar
2011-05-02 18:32           ` Corey Ashford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510093538.GA2569@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.intel.com \
    --cc=asharma@fb.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vweaver1@eecs.utk.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox