From: Alan Cox <alan@linux.intel.com>
To: Amit Virdi <amit.virdi@st.com>
Cc: <linux-input@vger.kernel.org>, <samuel@sortiz.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
Viresh KUMAR <viresh.kumar@st.com>
Subject: Re: BUG: sleeping function called from invalid context
Date: Tue, 10 May 2011 10:32:56 +0100 [thread overview]
Message-ID: <20110510103256.58d61861@bob.linux.org.uk> (raw)
In-Reply-To: <4DC8CF50.4040003@st.com>
> On analysis, I found that this is due to the change introduced in
> tty_ioctl.c where the termios mutex is taken to protect against
> parallel throttle/unthrottle. Probably IrCOMM stack code wasn't
> tested before merging this patch.
>
> Please suggest what should be done with the IrCOMM protocol stack
> code to resolve this problem?
It looks like the comments are wrong
/*
* Just give it over to the line discipline. There is no need to
* involve the flip buffers, since we are not running in an
interrupt
* handler
*/
appears to be completely untrue
I suspect it just needs to use the tty_flip_buffer functions properly
instead of trying to do clever shortcuts
tty_insert_flip_string(self->tty, skb->data, skb->len);
tty_flip_buffer_push(self->tty);
next prev parent reply other threads:[~2011-05-10 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 5:38 BUG: sleeping function called from invalid context Amit Virdi
2011-05-10 9:32 ` Alan Cox [this message]
2011-05-11 8:43 ` Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510103256.58d61861@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=shiraz.hashim@st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox