From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Robert Richter <robert.richter@amd.com>
Cc: Nicolas Kaiser <nikai@nikai.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"linux390@de.ibm.com" <linux390@de.ibm.com>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH resend] s390: oprofile: fix error checks in oprofile_hwsampler_init()
Date: Tue, 10 May 2011 11:19:26 +0200 [thread overview]
Message-ID: <20110510111926.788d7336@mschwide> (raw)
In-Reply-To: <20110510090054.GS31407@erda.amd.com>
On Tue, 10 May 2011 11:00:54 +0200
Robert Richter <robert.richter@amd.com> wrote:
> > Ok, the improved patch now looks like this:
> > --
> > Subject: [PATCH] s390: oprofile: fix min/max interval query checks
> >
> > From: Martin Schwidefsky <schwidefsky@de.ibm.com>
> >
> > oprofile_min_interval and oprofile_max_interval are unsigned, checking
> > for negative values doesn't work. Change hwsampler_query_min_interval
> > and hwsampler_query_max_interval to return an unsigned long and
> > check for a zero value instead.
> >
> > Reported-by: Nicolas Kaiser <nikai@nikai.net>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Looks good.
>
> Acked-by: Robert Richter <robert.richter@amd.com>
>
> Martin, can you queue this up?
Yes, I will do that.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2011-05-10 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 13:48 [PATCH resend] s390: oprofile: fix error checks in oprofile_hwsampler_init() Nicolas Kaiser
2011-05-02 15:01 ` Martin Schwidefsky
2011-05-03 8:55 ` Robert Richter
[not found] ` <BANLkTikC6vQF3p91q8e2E1Rp2M2HYyKipQ@mail.gmail.com>
2011-05-04 16:00 ` Maynard Johnson
2011-05-10 8:55 ` Martin Schwidefsky
2011-05-10 9:00 ` Robert Richter
2011-05-10 9:19 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510111926.788d7336@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=nikai@nikai.net \
--cc=oprofile-list@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox