* [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array"
@ 2011-05-10 11:10 Axel Lin
2011-05-10 11:27 ` Mark Brown
2011-05-10 19:56 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-05-10 11:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Yong Shen, Liam Girdwood, Mark Brown
I check this patch again and found this actually is not a bug
because MC13xxx_DEFINE explictly defines the order of each entry in the array.
Thus revert the patch.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/mc13892-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index ba909cb..1b8f739 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -259,6 +259,7 @@ static struct regulator_ops mc13892_sw_regulator_ops;
mc13xxx_regulator_ops)
static struct mc13xxx_regulator mc13892_regulators[] = {
+ MC13892_DEFINE_REGU(VCOINCELL, POWERCTL0, POWERCTL0, mc13892_vcoincell),
MC13892_SW_DEFINE(SW1, SWITCHERS0, SWITCHERS0, mc13892_sw1),
MC13892_SW_DEFINE(SW2, SWITCHERS1, SWITCHERS1, mc13892_sw),
MC13892_SW_DEFINE(SW3, SWITCHERS2, SWITCHERS2, mc13892_sw),
@@ -292,7 +293,6 @@ static struct mc13xxx_regulator mc13892_regulators[] = {
MC13892_GPO_DEFINE(GPO4, POWERMISC, mc13892_gpo),
MC13892_GPO_DEFINE(PWGT1SPI, POWERMISC, mc13892_pwgtdrv),
MC13892_GPO_DEFINE(PWGT2SPI, POWERMISC, mc13892_pwgtdrv),
- MC13892_DEFINE_REGU(VCOINCELL, POWERCTL0, POWERCTL0, mc13892_vcoincell),
};
static int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array"
2011-05-10 11:10 [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array" Axel Lin
@ 2011-05-10 11:27 ` Mark Brown
2011-05-10 19:56 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-05-10 11:27 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Yong Shen, Liam Girdwood
On Tue, May 10, 2011 at 07:10:36PM +0800, Axel Lin wrote:
> I check this patch again and found this actually is not a bug
> because MC13xxx_DEFINE explictly defines the order of each entry in the array.
>
> Thus revert the patch.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but this seems like something error prone that we probably want to
consider fixing anyway?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array"
2011-05-10 11:10 [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array" Axel Lin
2011-05-10 11:27 ` Mark Brown
@ 2011-05-10 19:56 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-05-10 19:56 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Yong Shen, Mark Brown
On Tue, 2011-05-10 at 19:10 +0800, Axel Lin wrote:
> I check this patch again and found this actually is not a bug
> because MC13xxx_DEFINE explictly defines the order of each entry in the array.
>
> Thus revert the patch.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-10 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-10 11:10 [PATCH] Revert "regulator: Move VCOINCELL to be the last element of mc13892_regulators array" Axel Lin
2011-05-10 11:27 ` Mark Brown
2011-05-10 19:56 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox