From: Andrew Morton <akpm@linux-foundation.org>
To: "Barnes, Clifton A." <cabarnes@indesign-llc.com>
Cc: "johnpol@2ka.mipt.ru" <johnpol@2ka.mipt.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH] w1: Add Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC support.
Date: Tue, 10 May 2011 15:28:41 -0700 [thread overview]
Message-ID: <20110510152841.68fabad2.akpm@linux-foundation.org> (raw)
In-Reply-To: <A8DC7EA93EFCBD4498E3857AFE65E5F13A3D90EB@IND07.indesign.net>
On Wed, 20 Apr 2011 19:57:05 +0000
"Barnes, Clifton A." <cabarnes@indesign-llc.com> wrote:
> Add support for the Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC.
>
> Another patch from Haojian Zhuang for this part was recently submitted,
> but I believe that this implementation is more consistent with other
> fuel gauge drivers since it uses the power supply interface.
>
hm, you're not a heavy user of scripts/checkpatch.pl, I see:
total: 190 errors, 704 warnings, 1221 lines checked
that must be a record.
>
> ...
>
> + new_setting = (u8)simple_strtoul(buf, &endp, 10);
This checkpatch warning is more than cosmetic:
WARNING: consider using kstrto* in preference to simple_strtoul
This is because simple_strtoul() will accept input of the form "42foo"
whereas strict_strtoul() (and, more recently, kstrtoul()) will reject
it. So fixing that sloppiness in the interface would be a userspace
API change, and we don't like those.
Please go through the patch and clean it up a bit?
prev parent reply other threads:[~2011-05-10 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:57 [PATCH] w1: Add Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC support Barnes, Clifton A.
2011-04-25 20:07 ` Andrew Morton
2011-05-09 10:55 ` Haojian Zhuang
2011-05-11 0:09 ` Ryan Mallon
2011-05-10 22:28 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510152841.68fabad2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cabarnes@indesign-llc.com \
--cc=haojian.zhuang@gmail.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox