From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Margarita Olaya <magi@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>,
grant.likely@secretlab.ca
Subject: Re: [PATCH 2/4] tps65912: gpio: add gpio driver
Date: Tue, 10 May 2011 22:39:33 +0200 [thread overview]
Message-ID: <20110510203933.GC8726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTikxbzmSNTMCvrPbfygS+iSUBhE=-Q@mail.gmail.com>
On Tue, May 10, 2011 at 03:25:35PM -0500, Margarita Olaya wrote:
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/tps65912-gpio.c | 94 ++++++++++++++++++++++++++++++++++++++++++
We're mostly moving GPIO drivers to drivers/gpio these days - there's a
push to move drivers into the appropriate subsystems (particularly
focused on arch/arm but still).
> +static void tps6591x_gpio_set(struct gpio_chip *gc, unsigned offset,
> + int value)
> +{
> + struct tps65912 *tps65912 = container_of(gc, struct tps65912, gpio);
> +
> + if (value)
> + tps65912_set_bits(tps65912, TPS65912_GPIO1 + offset,
> + GPIO_SET_MASK);
> + else
> + tps65912_set_bits(tps65912, TPS65912_GPIO1 + offset,
> + ~GPIO_SET_MASK);
Should one of those be clear_bits() given that there's such a function?
> + tps65912->gpio.owner = THIS_MODULE;
> + /* FIXME: should we use compilation macro for SPI */
> + tps65912->gpio.label = tps65912->i2c_client->name;
I guess dev_name() would do a reasonable job?
prev parent reply other threads:[~2011-05-10 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 20:25 [PATCH 2/4] tps65912: gpio: add gpio driver Margarita Olaya
2011-05-10 20:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510203933.GC8726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=magi@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox