From: Frederic Weisbecker <fweisbec@gmail.com>
To: Borislav Petkov <bp@amd64.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH 2/2] perf: Carve out callchain functionality
Date: Wed, 11 May 2011 15:30:12 +0200 [thread overview]
Message-ID: <20110511133009.GA1846@nowhere> (raw)
In-Reply-To: <1305119816-26280-3-git-send-email-bp@amd64.org>
On Wed, May 11, 2011 at 03:16:56PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Move callchain-related code into its own module:
> kernel/events/callchain.c
>
> No functionality change.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
> include/linux/perf_event.h | 7 +-
> kernel/events/Makefile | 2 +-
> kernel/events/callchain.c | 182 +++++++++++++++++++++++++++++++++
> kernel/events/core.c | 237 +++++--------------------------------------
> 4 files changed, 217 insertions(+), 211 deletions(-)
> create mode 100644 kernel/events/callchain.c
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 687f852..7978850 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -961,7 +961,6 @@ enum event_type_t {
> };
>
> #ifdef CONFIG_PERF_EVENTS
> -
> extern struct list_head pmus;
> extern int perf_pmu_register(struct pmu *pmu, char *name, int type);
> extern void perf_pmu_unregister(struct pmu *pmu);
> @@ -1201,6 +1200,12 @@ static inline void cpu_ctx_sched_in(struct perf_cpu_context *cpuctx,
> extern int
> task_function_call(struct task_struct *p, int (*func) (void *info), void *info);
> extern u64 perf_event_time(struct perf_event *event);
> +
> +extern int get_recursion_context(int *recursion);
> +extern inline void put_recursion_context(int *recursion, int rctx);
> +extern void put_callchain_buffers(void);
> +extern struct perf_callchain_entry *perf_callchain(struct pt_regs *regs);
> +extern int get_callchain_buffers(void);
I think it would be better to have these in a private kernel/events/events.h
Other than that, looks good, thanks.
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
next prev parent reply other threads:[~2011-05-11 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 13:16 [PATCH 0/2] perf: Split it some more Borislav Petkov
2011-05-11 13:16 ` [PATCH 1/2] perf: Carve out cgroup-related code Borislav Petkov
2011-05-11 13:33 ` Frederic Weisbecker
2011-05-11 13:48 ` Borislav Petkov
2011-05-11 13:16 ` [PATCH 2/2] perf: Carve out callchain functionality Borislav Petkov
2011-05-11 13:30 ` Frederic Weisbecker [this message]
2011-05-11 13:49 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511133009.GA1846@nowhere \
--to=fweisbec@gmail.com \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox