From: Vivek Goyal <vgoyal@redhat.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: fix typos on struct throtl_grp init code
Date: Wed, 11 May 2011 09:30:33 -0400 [thread overview]
Message-ID: <20110511133033.GD31633@redhat.com> (raw)
In-Reply-To: <1305120045-5111-1-git-send-email-namhyung@gmail.com>
On Wed, May 11, 2011 at 10:20:45PM +0900, Namhyung Kim wrote:
> s/td/tg/
I think jens would like to have little more changelog than that.
Otherwise looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> ---
> block/blk-throttle.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 0475a22a420d..d1e317e0fc34 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -201,7 +201,7 @@ static struct throtl_grp * throtl_find_alloc_tg(struct throtl_data *td,
> RB_CLEAR_NODE(&tg->rb_node);
> bio_list_init(&tg->bio_lists[0]);
> bio_list_init(&tg->bio_lists[1]);
> - td->limits_changed = false;
> + tg->limits_changed = false;
>
> /*
> * Take the initial reference that will be released on destroy
> @@ -1072,7 +1072,7 @@ int blk_throtl_init(struct request_queue *q)
> /* Practically unlimited BW */
> tg->bps[0] = tg->bps[1] = -1;
> tg->iops[0] = tg->iops[1] = -1;
> - td->limits_changed = false;
> + tg->limits_changed = false;
>
> /*
> * Set root group reference to 2. One reference will be dropped when
> --
> 1.7.5
next prev parent reply other threads:[~2011-05-11 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 13:01 [PATCH] blk-throttle: fix a typo in blk_throtl_init() Namhyung Kim
2011-05-11 13:07 ` Vivek Goyal
2011-05-11 13:20 ` [PATCH] blk-throttle: fix typos on struct throtl_grp init code Namhyung Kim
2011-05-11 13:30 ` Vivek Goyal [this message]
2011-05-11 14:14 ` Namhyung Kim
2011-05-11 14:28 ` Vivek Goyal
2011-05-11 14:38 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511133033.GD31633@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox