From: Borislav Petkov <bp@amd64.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
"Petkov, Borislav" <Borislav.Petkov@amd.com>
Subject: Re: [PATCH 2/2] perf: Carve out callchain functionality
Date: Wed, 11 May 2011 15:49:16 +0200 [thread overview]
Message-ID: <20110511134916.GC25827@aftab> (raw)
In-Reply-To: <20110511133009.GA1846@nowhere>
On Wed, May 11, 2011 at 09:30:12AM -0400, Frederic Weisbecker wrote:
> > +extern int get_recursion_context(int *recursion);
> > +extern inline void put_recursion_context(int *recursion, int rctx);
> > +extern void put_callchain_buffers(void);
> > +extern struct perf_callchain_entry *perf_callchain(struct pt_regs *regs);
> > +extern int get_callchain_buffers(void);
>
> I think it would be better to have these in a private kernel/events/events.h
>
> Other than that, looks good, thanks.
Yeah, I suggested a new header originally too but Ingo wanted to keep
perf_event.h as is, for now.
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2011-05-11 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 13:16 [PATCH 0/2] perf: Split it some more Borislav Petkov
2011-05-11 13:16 ` [PATCH 1/2] perf: Carve out cgroup-related code Borislav Petkov
2011-05-11 13:33 ` Frederic Weisbecker
2011-05-11 13:48 ` Borislav Petkov
2011-05-11 13:16 ` [PATCH 2/2] perf: Carve out callchain functionality Borislav Petkov
2011-05-11 13:30 ` Frederic Weisbecker
2011-05-11 13:49 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511134916.GC25827@aftab \
--to=bp@amd64.org \
--cc=Borislav.Petkov@amd.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox