From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Borislav Petkov <bp@amd64.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] perf: Carve out cgroup-related code
Date: Wed, 11 May 2011 16:00:31 +0200 [thread overview]
Message-ID: <20110511140031.GA18219@elte.hu> (raw)
In-Reply-To: <1305121600.2914.214.camel@laptop>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Wed, 2011-05-11 at 14:11 +0200, Borislav Petkov wrote:
> > include/linux/perf_event.h | 138 ++++++++++++-
>
> I don't like exposing all that in a kernel wide header.. should we maybe
> have kernel/events/internal.h?
Yeah.
We could eventually avoid exposing much of struct perf_event as well: arch PMU
drivers need the struct perf_event_attr, struct hw_perf_event and not much
else.
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-11 17:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 12:11 [RFC PATCH] perf: Carve out cgroup-related code Borislav Petkov
2011-05-11 13:46 ` Peter Zijlstra
2011-05-11 14:00 ` Ingo Molnar [this message]
2011-05-11 14:02 ` Borislav Petkov
2011-05-11 14:13 ` Ingo Molnar
2011-05-11 14:31 ` Borislav Petkov
2011-05-11 15:21 ` Ingo Molnar
2011-05-11 17:09 ` Borislav Petkov
2011-05-12 8:51 ` Peter Zijlstra
2011-05-12 8:54 ` Peter Zijlstra
2011-05-12 10:18 ` Borislav Petkov
2011-05-12 14:31 ` Frederic Weisbecker
2011-05-12 15:13 ` Lin Ming
2011-05-14 8:44 ` Borislav Petkov
2011-05-14 13:02 ` Frederic Weisbecker
2011-05-12 10:36 ` Ingo Molnar
2011-05-12 10:54 ` Borislav Petkov
2011-05-12 11:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511140031.GA18219@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@amd64.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox