public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Tao Ma <tm@tao.ma>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Jan Kara <jack@suse.cz>, Randy Dunlap <rdunlap@xenotime.net>,
	tytso@mit.edu
Subject: Re: [PATCH] Documentation: Remove the obsolete parameters in 2 jbd2 functions.
Date: Wed, 11 May 2011 16:56:04 +0200	[thread overview]
Message-ID: <20110511145604.GF5057@quack.suse.cz> (raw)
In-Reply-To: <1305123521-2896-1-git-send-email-tm@tao.ma>

On Wed 11-05-11 22:18:41, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> credits isn't a parameter for jbd2_journal_get_write_access and
> jbd2_journal_get_undo_access. So remove the corresponding comments.
> 
> Cc: Jan Kara <jack@suse.cz>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
  For JBD2 changes please CC also Ted Ts'o <tytso@mit.edu> since he is
merging JBD2 patches. The patch is fine. Thanks.

								Honza
> ---
>  fs/jbd2/transaction.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..0a82612 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -813,7 +813,6 @@ out:
>   * int jbd2_journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update.
>   * @handle: transaction to add buffer modifications to
>   * @bh:     bh to be used for metadata writes
> - * @credits: variable that will receive credits for the buffer
>   *
>   * Returns an error code or 0 on success.
>   *
> @@ -931,7 +930,6 @@ out:
>   *     non-rewindable consequences
>   * @handle: transaction
>   * @bh: buffer to undo
> - * @credits: store the number of taken credits here (if not NULL)
>   *
>   * Sometimes there is a need to distinguish between metadata which has
>   * been committed to disk and that which has not.  The ext3fs code uses
> -- 
> 1.7.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2011-05-11 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 14:18 [PATCH] Documentation: Remove the obsolete parameters in 2 jbd2 functions Tao Ma
2011-05-11 14:56 ` Jan Kara [this message]
2011-05-11 21:59   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110511145604.GF5057@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=tm@tao.ma \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox