From: Andrew Morton <akpm@linux-foundation.org>
To: rtc-linux@googlegroups.com
Cc: Chris Metcalf <cmetcalf@tilera.com>,
linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [rtc-linux] [PATCH] tile: add an RTC driver for the Tilera hypervisor
Date: Wed, 11 May 2011 15:44:07 -0700 [thread overview]
Message-ID: <20110511154407.ed3c0480.akpm@linux-foundation.org> (raw)
In-Reply-To: <201105042004.p44K4hh5011720@farm-0032.internal.tilera.com>
On Wed, 4 May 2011 15:52:21 -0400
Chris Metcalf <cmetcalf@tilera.com> wrote:
> This is a simple RTC driver that lets Tilera hardware boot up and
> set the clock correctly.
>
>
> ...
>
> +static int __init tile_rtc_driver_init(void)
> +{
> + int err;
> +
> + err = platform_driver_register(&tile_rtc_platform_driver);
> + if (err)
> + return err;
> +
> + tile_rtc_platform_device = platform_device_alloc("rtc-tile", 0);
> + if (tile_rtc_platform_device == NULL) {
> + platform_driver_unregister(&tile_rtc_platform_driver);
> + return -ENOMEM;
> + }
> +
> + err = platform_device_add(tile_rtc_platform_device);
> + if (err) {
> + platform_device_put(tile_rtc_platform_device);
should we have a platform_driver_unregister() here?
> + return err;
> + }
> +
> + return 0;
> +}
>
> ...
>
next prev parent reply other threads:[~2011-05-11 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:52 [PATCH] tile: add an RTC driver for the Tilera hypervisor Chris Metcalf
2011-05-11 22:44 ` Andrew Morton [this message]
2011-05-12 18:33 ` [rtc-linux] " Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511154407.ed3c0480.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox