From: Greg KH <greg@kroah.com>
To: matt mooney <mfmooney@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent
Date: Wed, 11 May 2011 14:06:39 -0700 [thread overview]
Message-ID: <20110511210639.GA4679@kroah.com> (raw)
In-Reply-To: <0c3a71ba4811a3ab470d307650067e9c2b52379b.1305103212.git.mfm@muteddisk.com>
On Wed, May 11, 2011 at 01:54:16AM -0700, matt mooney wrote:
> This switches all of the non dev_<level> print statements to use the
> pr_<level> macros. And a few debug statements are removed.
Can't most of these be moved to use the dev_* calls instead?
>
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
> drivers/staging/usbip/stub_dev.c | 22 ++--
> drivers/staging/usbip/stub_main.c | 19 ++--
> drivers/staging/usbip/stub_rx.c | 24 ++--
> drivers/staging/usbip/stub_tx.c | 16 ++--
> drivers/staging/usbip/usbip_common.c | 228 +++++++++++++++------------------
> drivers/staging/usbip/usbip_common.h | 46 +------
> drivers/staging/usbip/usbip_event.c | 3 +-
> drivers/staging/usbip/vhci_hcd.c | 87 +++++--------
> drivers/staging/usbip/vhci_rx.c | 33 +++---
> drivers/staging/usbip/vhci_sysfs.c | 14 +-
> drivers/staging/usbip/vhci_tx.c | 8 +-
> 11 files changed, 209 insertions(+), 291 deletions(-)
>
> diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
> index c71d0a3..0c0d838 100644
> --- a/drivers/staging/usbip/stub_dev.c
> +++ b/drivers/staging/usbip/stub_dev.c
> @@ -196,7 +196,7 @@ static void stub_shutdown_connection(struct usbip_device *ud)
> * step 1?
> */
> if (ud->tcp_socket) {
> - usbip_udbg("shutdown tcp_socket %p\n", ud->tcp_socket);
> + pr_debug("shutdown tcp_socket %p\n", ud->tcp_socket);
Like here, we have a valid struct device pointer from what I can tell,
so we should use dev_dbg() instead of pr_debug().
I think a lot of these conversions could use those calls here, right?
So care to split this into 2 patches, one that converts to valid usages
of the dev_* calls, and the other a patch that converts the rest to pr_*
calls?
thanks,
greg k-h
next prev parent reply other threads:[~2011-05-11 21:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 8:54 [PATCH 00/12] staging: usbip: miscellaneous code cleanup matt mooney
2011-05-11 8:54 ` [PATCH 01/12] staging: usbip: change debug configuration option matt mooney
2011-05-11 8:54 ` [PATCH 02/12] staging: usbip: use single version for all modules matt mooney
2011-05-11 8:54 ` [PATCH 03/12] staging: usbip: fix header includes matt mooney
2011-05-11 21:07 ` Greg KH
2011-05-11 22:54 ` matt mooney
2011-05-11 8:54 ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent matt mooney
2011-05-11 21:06 ` Greg KH [this message]
2011-05-11 22:51 ` matt mooney
2011-05-11 23:19 ` Greg KH
2011-05-11 8:54 ` [PATCH 05/12] staging: usbip: remove unnecessary lines and extra return statements matt mooney
2011-05-11 8:54 ` [PATCH 06/12] staging: usbip: stub_main.c: code cleanup matt mooney
2011-05-11 21:08 ` Greg KH
2011-05-11 22:56 ` matt mooney
2011-05-11 8:54 ` [PATCH 07/12] staging: usbip: stub_main.c: change __init/__exit prefix and use KMEM_CACHE matt mooney
2011-05-11 8:54 ` [PATCH 08/12] staging: usbip: usbip_common.c: fix misspelled function name matt mooney
2011-05-11 8:54 ` [PATCH 09/12] staging: usbip: edit Kconfig and rename CONFIG options matt mooney
2011-05-11 21:09 ` Greg KH
2011-05-11 8:54 ` [PATCH 10/12] staging: usbip: stub.h: reorganize matt mooney
2011-05-11 8:54 ` [PATCH 11/12] staging: usbip: vhci.h: reorganize matt mooney
2011-05-11 8:54 ` [PATCH 12/12] staging: usbip: usbip_common.h: reorganize and document request headers matt mooney
2011-05-11 21:14 ` [PATCH 00/12] staging: usbip: miscellaneous code cleanup Greg KH
2011-05-11 23:08 ` matt mooney
2011-05-11 23:18 ` Greg KH
2011-05-12 3:24 ` matt mooney
2011-05-12 5:31 ` Greg KH
2011-05-12 5:41 ` matt mooney
2011-05-12 16:38 ` Greg KH
2011-05-12 5:08 ` [PATCH 09/12 v2] staging: usbip: edit Kconfig and rename CONFIG options mfmooney
2011-05-12 5:08 ` [PATCH 03/12 v2] staging: usbip: fix header includes mfmooney
2011-05-12 5:17 ` [PATCH 09/12 v3] staging: usbip: edit Kconfig and rename CONFIG options mfmooney
2011-05-12 5:32 ` Greg KH
2011-05-12 5:32 ` matt mooney
2011-05-12 13:34 ` [PATCH 00/12] staging: usbip: miscellaneous code cleanup Matthew Wilcox
2011-05-12 18:37 ` matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511210639.GA4679@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfmooney@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox