From: Frederic Weisbecker <fweisbec@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
oprofile-list@lists.sf.net, oleg@redhat.com,
akpm@linux-foundation.org, ying.huang@intel.com, ssp@redhat.com,
namhyung@gmail.com, x86@kernel.org, hpa@zytor.com,
tglx@linutronix.de, robert.richter@amd.com,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops
Date: Thu, 12 May 2011 00:37:23 +0200 [thread overview]
Message-ID: <20110511223719.GC1846@nowhere> (raw)
In-Reply-To: <1304709791-4232-1-git-send-email-richard@nod.at>
On Fri, May 06, 2011 at 09:23:11PM +0200, Richard Weinberger wrote:
> Both warning and warning_symbol are nowhere used.
> Let's get rid of them.
I have no clue what it was used for. But fine let's assume
it's a leftover of some previous removal.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/sh/include/asm/stacktrace.h | 3 ---
> arch/sh/kernel/dumpstack.c | 15 ---------------
> arch/sh/kernel/perf_callchain.c | 12 ------------
> arch/sh/kernel/stacktrace.c | 13 -------------
> arch/sh/oprofile/backtrace.c | 13 -------------
Can you please split your patch in two parts: one for sh and
another for x86?
Thanks.
> arch/x86/include/asm/stacktrace.h | 3 ---
> arch/x86/kernel/cpu/perf_event.c | 13 -------------
> arch/x86/kernel/dumpstack.c | 16 ----------------
> arch/x86/kernel/stacktrace.c | 13 -------------
> arch/x86/oprofile/backtrace.c | 13 -------------
> 10 files changed, 0 insertions(+), 114 deletions(-)
next prev parent reply other threads:[~2011-05-11 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 19:23 [PATCH] [RFC] remove warning and warning_symbol from struct stacktrace_ops Richard Weinberger
2011-05-11 22:37 ` Frederic Weisbecker [this message]
2011-05-12 12:48 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511223719.GC1846@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=oleg@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=richard@nod.at \
--cc=robert.richter@amd.com \
--cc=ssp@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox