Re: [RFC PATCH] perf: Carve out cgroup-related code

[Borislav Petkov <bp@amd64.org>]

On Thu, May 12, 2011 at 06:36:44AM -0400, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@amd64.org> wrote:
> 
> > Done, patch below. I've moved all exports local to kernel/events/* to
> > internal.h. Branch at
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git perf-split
> 
> Beyond the things Peter noticed, there's also this new bit in perf_event.h:
> 
> enum event_type_t {
>         EVENT_FLEXIBLE = 0x1,
>         EVENT_PINNED = 0x2,
>         EVENT_ALL = EVENT_FLEXIBLE | EVENT_PINNED,
> };
> 
> this got there from core.c, albeit it's only core.c that uses it.
> 
> If then this should move to internal.h - or stay local to core.c.

event_type_t gets pulled by pushing

ctx_sched_out(..., enum event_type_t event_type)

up into the header since otherwise gcc complains of not seeing the
definition of the third argument.

And yes, it should go to internal.h.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632