From: Arnd Bergmann <arnd@arndb.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Subhasish Ghosh <subhasish@mistralsolutions.com>,
sachi@mistralsolutions.com,
davinci-linux-open-source@linux.davincidsp.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Netdev@vger.kernel.org, nsekhar@ti.com,
open list <linux-kernel@vger.kernel.org>,
CAN NETWORK DRIVERS <socketcan-core@lists.berlios.de>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
m-watkins@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/1] can: add pruss CAN driver.
Date: Thu, 12 May 2011 14:54:47 +0200 [thread overview]
Message-ID: <201105121454.47781.arnd@arndb.de> (raw)
In-Reply-To: <4DCB88A4.2010901@grandegger.com>
On Thursday 12 May 2011, Wolfgang Grandegger wrote:
> Well, that seems sophisticated resulting in a complex implementation
> (may code line) also because hardware filters are very hardware
> dependent. Usually just one global filter can be defined. I think that's
> overkill. A simple interface using:
>
> ip link set can0 type can filter <id>:<mask> [<id>:<mask> ...]
>
> would just be fine.
Ok, fair enough. Still I would suggest you first come up with
a reasonable user interface (the one you posted may be just right,
I don't know), and then let someone do the implementation in the
pruss firmware that is the best match for the user interface, rather
than the other way around.
Arnd
next prev parent reply other threads:[~2011-05-12 12:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1303474267-6344-1-git-send-email-subhasish@mistralsolutions.com>
2011-04-22 12:11 ` [PATCH v4 1/1] can: add pruss CAN driver Subhasish Ghosh
[not found] ` <4DB1A3B7.7060300@pengutronix.de>
2011-04-25 20:06 ` Wolfgang Grandegger
2011-04-27 13:08 ` Subhasish Ghosh
2011-04-27 13:21 ` Marc Kleine-Budde
2011-04-27 13:25 ` Arnd Bergmann
2011-05-04 7:13 ` Subhasish Ghosh
2011-05-04 13:11 ` Arnd Bergmann
2011-05-04 14:33 ` Wolfgang Grandegger
2011-05-04 14:48 ` Arnd Bergmann
2011-05-04 16:00 ` Wolfgang Grandegger
2011-05-10 10:11 ` Subhasish Ghosh
2011-05-10 10:27 ` Alan Cox
2011-05-10 12:21 ` Subhasish Ghosh
2011-05-11 21:31 ` Arnd Bergmann
2011-05-11 21:44 ` Arnd Bergmann
2011-05-11 22:39 ` Marc Kleine-Budde
2011-05-11 22:56 ` Alan Cox
2011-05-12 3:03 ` can: hardware vs. software filter Kurt Van Dijck
2011-05-12 7:13 ` [PATCH v4 1/1] can: add pruss CAN driver Wolfgang Grandegger
2011-05-12 10:58 ` Kurt Van Dijck
2011-05-12 12:54 ` Arnd Bergmann [this message]
2011-05-12 13:04 ` Marc Kleine-Budde
2011-05-12 14:41 ` Oliver Hartkopp
2011-05-22 10:30 ` Arnd Bergmann
2011-05-23 6:21 ` Oliver Hartkopp
2011-05-23 8:23 ` Marc Kleine-Budde
2011-05-27 8:31 ` Wolfgang Grandegger
2011-05-12 7:04 ` Wolfgang Grandegger
2011-05-04 15:57 ` Kurt Van Dijck
2011-05-04 16:09 ` Wolfgang Grandegger
2011-05-04 20:55 ` Oliver Hartkopp
2011-04-27 13:28 ` Wolfgang Grandegger
2011-04-27 13:34 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105121454.47781.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Netdev@vger.kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-watkins@ti.com \
--cc=mkl@pengutronix.de \
--cc=nsekhar@ti.com \
--cc=sachi@mistralsolutions.com \
--cc=socketcan-core@lists.berlios.de \
--cc=subhasish@mistralsolutions.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox