From: Andrew Morton <akpm@linux-foundation.org>
To: John Stultz <john.stultz@linaro.org>
Cc: David Rientjes <rientjes@google.com>,
LKML <linux-kernel@vger.kernel.org>, "Ted Ts'o" <tytso@mit.edu>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/3] comm: ext4: Protect task->comm access by using %ptc
Date: Thu, 12 May 2011 15:34:11 -0700 [thread overview]
Message-ID: <20110512153411.15c240bc.akpm@linux-foundation.org> (raw)
In-Reply-To: <1305239380.2680.26.camel@work-vm>
On Thu, 12 May 2011 15:29:40 -0700
John Stultz <john.stultz@linaro.org> wrote:
> On Thu, 2011-05-12 at 15:14 -0700, David Rientjes wrote:
> > On Tue, 10 May 2011, John Stultz wrote:
> >
> > > Converts ext4 comm access to use the safe printk %ptc accessor.
> > >
> > > CC: Ted Ts'o <tytso@mit.edu>
> > > CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > > CC: David Rientjes <rientjes@google.com>
> > > CC: Dave Hansen <dave@linux.vnet.ibm.com>
> > > CC: Andrew Morton <akpm@linux-foundation.org>
> > > CC: linux-mm@kvack.org
> > > Signed-off-by: John Stultz <john.stultz@linaro.org>
> >
> > I like how this patch illustrates how easy it is to use the new method for
> > printing a task's command, but it would probably be easier to get the
> > first two patches in the series (those that add the seqlock and then %ptc)
> > merged in mainline and then break out a series of conversions such as this
> > that could go through the individual maintainer's trees.
>
> Agreed. I just wanted to show how it would be used compared to the
> earlier approach.
>
> I'll respin the first two patches shortly here. I also need to get the
> checkpatch bit done.
>
> Andrew, should these go upstream through you?
>
That works. I have a little pile of task->comm patches here, but I
expect that resolving everything will be pretty straightforward.
Don't forget the checkpatch patch :)
prev parent reply other threads:[~2011-05-12 22:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 0:23 [RFC][PATCH 0/3] v2 Improve task->comm locking situation John Stultz
2011-05-11 0:23 ` [PATCH 1/3] comm: Introduce comm_lock seqlock to protect task->comm access John Stultz
2011-05-11 17:39 ` Andi Kleen
2011-05-12 22:00 ` David Rientjes
2011-05-11 0:23 ` [PATCH 2/3] printk: Add %ptc to safely print a task's comm John Stultz
2011-05-11 0:51 ` Joe Perches
2011-05-11 1:10 ` John Stultz
2011-05-11 1:16 ` john stultz
2011-05-11 1:20 ` Joe Perches
2011-05-12 22:12 ` David Rientjes
2011-05-12 22:29 ` Joe Perches
2011-05-13 21:56 ` David Rientjes
2011-05-12 22:10 ` David Rientjes
2011-05-11 9:33 ` Américo Wang
2011-05-11 21:02 ` John Stultz
2011-05-12 10:43 ` Américo Wang
2011-05-12 10:45 ` Américo Wang
2011-05-12 18:01 ` John Stultz
2011-05-11 17:36 ` Andi Kleen
2011-05-11 21:04 ` John Stultz
2011-05-11 0:23 ` [PATCH 3/3] comm: ext4: Protect task->comm access by using %ptc John Stultz
2011-05-12 22:14 ` David Rientjes
2011-05-12 22:29 ` John Stultz
2011-05-12 22:34 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512153411.15c240bc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=john.stultz@linaro.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).