public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/2] x86: Make the x86-64 stacktrace code safely callable from scheduler
Date: Thu, 12 May 2011 22:40:54 +0200	[thread overview]
Message-ID: <20110512204051.GD7410@nowhere> (raw)
In-Reply-To: <1305232326-9804-3-git-send-email-fweisbec@gmail.com>

On Thu, May 12, 2011 at 10:32:06PM +0200, Frederic Weisbecker wrote:
> Avoid potential scheduler recursion and deadlock from the
> stacktrace code by avoiding rescheduling when we re-enable
> preemption.
> 
> This robustifies some scheduler trace events like sched switch
> when they are used to produce callchains in perf or ftrace.

Actually trace events are already safe because they already disable
preemption so callchains won't call schedule() there. But still
let's be careful, we never know how stacktrace can be used.

  reply	other threads:[~2011-05-12 20:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 20:32 [GIT PULL] x86 stacktrace updates Frederic Weisbecker
2011-05-12 20:32 ` [PATCH 1/2] x86: Remove warning and warning_symbol from struct stacktrace_ops Frederic Weisbecker
2011-07-14 11:01   ` Mel Gorman
2011-07-14 13:50     ` Frederic Weisbecker
2011-05-12 20:32 ` [PATCH 2/2] x86: Make the x86-64 stacktrace code safely callable from scheduler Frederic Weisbecker
2011-05-12 20:40   ` Frederic Weisbecker [this message]
2011-05-12 21:28   ` Ingo Molnar
2011-05-12 21:43     ` Frederic Weisbecker
2011-05-12 21:55       ` Ingo Molnar
2011-05-13 10:48   ` Steven Rostedt
2011-05-13 12:48     ` Frederic Weisbecker
2011-05-13 13:19       ` Peter Zijlstra
2011-05-13 13:29         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512204051.GD7410@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox