linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Raffaele Recalcati <lamiaposta71@gmail.com>
Cc: linux-pm@lists.linux-foundation.org,
	davinci-linux-open-source@linux.davincidsp.com,
	linux-kernel@vger.kernel.org,
	Davide Ciminaghi <ciminaghi@gnudd.com>
Subject: Re: [PATCH 1/4] export bus_kset
Date: Thu, 12 May 2011 21:28:53 +0200	[thread overview]
Message-ID: <201105122128.54172.rjw@sisk.pl> (raw)
In-Reply-To: <1305220265-9020-2-git-send-email-lamiaposta71@gmail.com>

On Thursday, May 12, 2011, Raffaele Recalcati wrote:
> From: Davide Ciminaghi <ciminaghi@gnudd.com>

Please explain why you need to export it, what the alternatives are and
why you think this approach is better than the alternatives.

Thanks,
Rafael


> Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>
> ---
>  drivers/base/bus.c      |    3 ++-
>  include/linux/kobject.h |    2 ++
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 000e7b2..2134248 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -158,7 +158,8 @@ static const struct kset_uevent_ops bus_uevent_ops = {
>  	.filter = bus_uevent_filter,
>  };
>  
> -static struct kset *bus_kset;
> +struct kset *bus_kset;
> +EXPORT_SYMBOL(bus_kset);
>  
>  
>  #ifdef CONFIG_HOTPLUG
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index 8f6d121..456b20d 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -205,6 +205,8 @@ extern struct kobject *power_kobj;
>  /* The global /sys/firmware/ kobject for people to chain off of */
>  extern struct kobject *firmware_kobj;
>  
> +extern struct kset *bus_kset ;
> +
>  #if defined(CONFIG_HOTPLUG)
>  int kobject_uevent(struct kobject *kobj, enum kobject_action action);
>  int kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
> 


  reply	other threads:[~2011-05-12 19:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 17:11 pm loss development Raffaele Recalcati
2011-05-12 17:11 ` [PATCH 1/4] export bus_kset Raffaele Recalcati
2011-05-12 19:28   ` Rafael J. Wysocki [this message]
2011-05-13 17:11     ` Davide Ciminaghi
2011-05-15 14:13       ` [linux-pm] " Davide Ciminaghi
2011-05-17 23:04         ` Rafael J. Wysocki
2011-05-12 17:11 ` [PATCH 2/4] PM / Loss: power loss management Raffaele Recalcati
2011-05-12 19:57   ` Rafael J. Wysocki
2011-05-13 13:02     ` Davide Ciminaghi
2011-05-17 23:32       ` Rafael J. Wysocki
2011-05-19  9:26         ` Davide Ciminaghi
2011-05-19 14:25           ` [linux-pm] " Alan Stern
2011-05-19 20:52             ` Rafael J. Wysocki
2011-05-12 17:11 ` [PATCH 3/4] mmc: bus and block device drivers: support for pm_loss Raffaele Recalcati
2011-05-12 17:11 ` [PATCH 4/4] DaVinci: vpfe: " Raffaele Recalcati
2011-05-12 19:27 ` pm loss development Rafael J. Wysocki
2011-05-13  6:39   ` Raffaele Recalcati
2011-05-13 16:54     ` Rafael J. Wysocki
2011-05-14 16:35       ` [linux-pm] " mark gross
2011-05-17 23:07         ` Rafael J. Wysocki
2011-05-18  3:12           ` mark gross
2011-05-18 19:43             ` Rafael J. Wysocki
2011-05-18 22:17               ` Mark Brown
2011-05-19 12:45               ` mark gross
2011-06-02 22:21               ` Pavel Machek
2011-06-14 14:06                 ` mark gross
2011-06-14 14:36                   ` Alan Cox
2011-05-14 20:21       ` Raffaele Recalcati
2011-05-17 23:10         ` Rafael J. Wysocki
2011-05-14 18:53   ` [linux-pm] " Oliver Neukum
2011-05-14 20:34     ` Raffaele Recalcati
2011-05-17 23:06       ` Rafael J. Wysocki
2011-05-14 16:24 ` mark gross
2011-05-14 20:30   ` Raffaele Recalcati
2011-05-14 23:33     ` mark gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105122128.54172.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ciminaghi@gnudd.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=lamiaposta71@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).