From: Ingo Molnar <mingo@elte.hu>
To: Greg KH <greg@kroah.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
Phil Carmody <ext-phil.2.carmody@nokia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sysfs: remove "last sysfs file:" line from the oops messages
Date: Fri, 13 May 2011 09:28:15 +0200 [thread overview]
Message-ID: <20110513072815.GA10584@elte.hu> (raw)
In-Reply-To: <20110512230102.GA19069@kroah.com>
* Greg KH <greg@kroah.com> wrote:
> ---------------
> I'm going to queue this up for the .40 kernel merge window, any
> objections?
> ---------------
> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -279,7 +279,6 @@ int __kprobes __die(const char *str, struct pt_regs *regs, long err)
> printk("DEBUG_PAGEALLOC");
> #endif
> printk("\n");
> - sysfs_printk_last_file();
> if (notify_die(DIE_OOPS, str, regs, err,
> current->thread.trap_no, SIGSEGV) == NOTIFY_STOP)
> return 1;
Good idea - that line has become quite a bit less useful over the past few
years and oops output is valuable screen real estate.
Acked-by: Ingo Molnar <mingo@elte.hu>
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-13 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 23:01 [PATCH] sysfs: remove "last sysfs file:" line from the oops messages Greg KH
2011-05-13 7:28 ` Ingo Molnar [this message]
2011-05-13 9:23 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513072815.GA10584@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=ext-phil.2.carmody@nokia.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox