From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>,
Yong Zhang <yong.zhang0@gmail.com>,
Carl-Johan Kjellander <carl-johan@klarna.com>,
linux-kernel@vger.kernel.org
Subject: Re: Sched_autogroup and niced processes
Date: Fri, 13 May 2011 12:04:11 +0200 [thread overview]
Message-ID: <20110513100411.GA21022@elte.hu> (raw)
In-Reply-To: <1305279990.2466.4.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Fri, 2011-05-13 at 11:29 +0200, Ingo Molnar wrote:
> > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> >
> > > On Fri, 2011-05-13 at 11:05 +0200, Ingo Molnar wrote:
> > > > Could we somehow automate this:
> > > >
> > > > > echo 19 > /proc/'pid of seti@home'/autogroup
> > > >
> > > > and split off nice 19 tasks into separate groups and lower the group's
> > > > priority?
> > >
> > > Well I guess you can stack on all kinds of heuristics, do we want to?
> >
> > Well have you seen my non-heuristic suggestion:
> >
> > | Another thing we could do is to lower the priority of a cgroup if it *only*
> > | runs reniced tasks. I.e. track the 'maximum priority' of cgroups and
> > | propagate that to their weight.
> > |
> > | This way renicing within cgroups will be more powerful and people do not have
> > | to muck with cgroup details.
> >
> > A cgroup assuming the highest priority of all tasks it contains is a pretty
> > natural definition and extension of priorities and also solves this usecase.
>
> Well, that a heuristic in my book, and it totally destroys the independence
> of groups from tasks (resulting in O(n) task nice behaviour).
>
> I really don't see why we should do this, if people don't want what it does,
> don't use it. If you want something else, you can do all these things from
> userspace to suit your exact needs.
>
> We have enough knobs to set things up as you want them, no need to make
> things more complicated.
Ok, i guess you are right, propagating priorities does break the clean
hieararchy we have currently.
Still, the other important problem is that we still seem to have a bug, even
with the cgroup set to low prio seti@home is sucking up CPU resources ...
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-13 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 7:39 Sched_autogroup and niced processes Carl-Johan Kjellander
2011-05-13 7:53 ` Yong Zhang
2011-05-13 8:05 ` Mike Galbraith
2011-05-13 8:22 ` Ingo Molnar
2011-05-13 8:41 ` Peter Zijlstra
2011-05-13 9:05 ` Ingo Molnar
2011-05-13 9:07 ` Peter Zijlstra
2011-05-13 9:14 ` Carl-Johan Kjellander
2011-05-13 9:29 ` Ingo Molnar
2011-05-13 9:46 ` Peter Zijlstra
2011-05-13 10:04 ` Ingo Molnar [this message]
2011-05-13 13:13 ` Mike Galbraith
2011-05-13 13:24 ` Peter Zijlstra
2011-05-13 13:36 ` Carl-Johan Kjellander
2011-05-13 14:06 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513100411.GA21022@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=carl-johan@klarna.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox