From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Kevin Cernekee <cernekee@gmail.com>,
Wu Zhangjin <wuzhangjin@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning
Date: Fri, 13 May 2011 11:17:16 +0100 [thread overview]
Message-ID: <20110513101716.GB25345@linux-mips.org> (raw)
In-Reply-To: <4DAC7499.5000602@gmail.com>
On Mon, Apr 18, 2011 at 10:27:53AM -0700, David Daney wrote:
> >It's been two years since the original discussion, and the warning is
> >still there. It is now the only warning left in my kernel build.
> >
> >I was hoping we could get this resolved for good (one way or another).
[...]
> NAK.
>
> I think Ralf's idea in the e-mail you referenced is the proper approach.
>
> Change pci_fixup_irqs(...) to take a 'const struct pci_dev *'
> instead. There is a lot of work going on in the kernel to constify
> things. This should be fairly easy to get accepted.
It's a fairly big manual job but should be just right for spatch.
Ralf
next prev parent reply other threads:[~2011-05-13 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 19:01 [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning Kevin Cernekee
2011-04-18 17:27 ` David Daney
2011-05-13 10:17 ` Ralf Baechle [this message]
2011-05-19 13:15 ` [PATCH] PCI: Make the struct pci_dev * argument of map_irq const Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513101716.GB25345@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cernekee@gmail.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox