From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>,
grant.likely@secretlab.ca
Subject: Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver
Date: Sat, 14 May 2011 15:29:45 -0700 [thread overview]
Message-ID: <20110514222944.GD21792@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110513165931.GK8970@sortiz-mobl>
On Fri, May 13, 2011 at 06:59:32PM +0200, Samuel Ortiz wrote:
> On Wed, May 04, 2011 at 07:21:46PM -0500, Jorge Eduardo Candelaria wrote:
> > +config TPS65911_COMPARATOR
> > + tristate "TPS65911 Comparator"
> > + depends on MFD_TPS65910
> > + help
> > + if you say yes here you get support for the TPS65910 comparator
> > + module.
> I still don't know what it compares and why I would want to enable that.
It'll be comparing two voltages - it's quite a common feature for PMICs
with auxadcs. I think I said in one of my previous reviews that it
probably shouldn't be user visible in Kconfig as some other driver will
need to be written to call it so that driver could just select the
symbol.
> This driver really looks like it could belong to drivers/regulator.
It's measuring rather than producing.
next prev parent reply other threads:[~2011-05-14 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 0:21 [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver Jorge Eduardo Candelaria
2011-05-13 16:59 ` Samuel Ortiz
2011-05-14 22:29 ` Mark Brown [this message]
2011-05-22 20:40 ` Samuel Ortiz
2011-05-22 22:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514222944.GD21792@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox