* [PATCH 2/3] preferred form for passing a size to memory allocation routines
@ 2011-05-14 17:55 anish
2011-05-15 9:37 ` Harry Wei
2011-05-16 15:49 ` [PATCH 2/3] preferred form for passing a size to memory allocation routines[staging sm7xx] anish
0 siblings, 2 replies; 3+ messages in thread
From: anish @ 2011-05-14 17:55 UTC (permalink / raw)
To: greg, teddy.wang; +Cc: linux-kernel
The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
Please refer Documentation/Codingstyle chapter 14
Signed-off-by: anish kumar<anish198519851985@gmail.com>
---
drivers/staging/sm7xx/smtcfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/sm7xx/smtcfb.c
b/drivers/staging/sm7xx/smtcfb.c
index c1b8228..d1dd387 100644
--- a/drivers/staging/sm7xx/smtcfb.c
+++ b/drivers/staging/sm7xx/smtcfb.c
@@ -684,7 +684,7 @@ static struct smtcfb_info *smtc_alloc_fb_info(struct
pci_dev *dev,
{
struct smtcfb_info *sfb;
- sfb = kzalloc(sizeof(struct smtcfb_info), GFP_KERNEL);
+ sfb = kzalloc(sizeof(*sfb), GFP_KERNEL);
if (!sfb)
return NULL;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] preferred form for passing a size to memory allocation routines
2011-05-14 17:55 [PATCH 2/3] preferred form for passing a size to memory allocation routines anish
@ 2011-05-15 9:37 ` Harry Wei
2011-05-16 15:49 ` [PATCH 2/3] preferred form for passing a size to memory allocation routines[staging sm7xx] anish
1 sibling, 0 replies; 3+ messages in thread
From: Harry Wei @ 2011-05-15 9:37 UTC (permalink / raw)
To: anish; +Cc: greg, linux-kernel
On Sat, May 14, 2011 at 11:25:04PM +0530, anish wrote:
> The preferred form for passing a size of a struct is the following:
> p = kmalloc(sizeof(*p), ...);
> Please refer Documentation/Codingstyle chapter 14
> Signed-off-by: anish kumar<anish198519851985@gmail.com>
> - sfb = kzalloc(sizeof(struct smtcfb_info), GFP_KERNEL);
> + sfb = kzalloc(sizeof(*sfb), GFP_KERNEL);
Hi anish,
Good catch ;)
Acked-by: Harry Wei <harryxiyou@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/3] preferred form for passing a size to memory allocation routines[staging sm7xx]
2011-05-14 17:55 [PATCH 2/3] preferred form for passing a size to memory allocation routines anish
2011-05-15 9:37 ` Harry Wei
@ 2011-05-16 15:49 ` anish
1 sibling, 0 replies; 3+ messages in thread
From: anish @ 2011-05-16 15:49 UTC (permalink / raw)
To: greg, teddy.wang, anish198519851985; +Cc: linux-kernel, harryxiyou
The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
Please refer Documentation/Codingstyle chapter 14
Signed-off-by: anish kumar<anish198519851985@gmail.com>
Acked-by: Harry Wei <harryxiyou@gmail.com>
---
drivers/staging/sm7xx/smtcfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/sm7xx/smtcfb.c b/drivers/staging/sm7xx/smtcfb.c
index 1aca0cb..c41d2f7 100644
--- a/drivers/staging/sm7xx/smtcfb.c
+++ b/drivers/staging/sm7xx/smtcfb.c
@@ -714,7 +714,7 @@ static struct smtcfb_info *smtc_alloc_fb_info(struct pci_dev *dev,
{
struct smtcfb_info *sfb;
- sfb = kzalloc(sizeof(struct smtcfb_info), GFP_KERNEL);
+ sfb = kzalloc(sizeof(*sfb), GFP_KERNEL);
if (!sfb)
return NULL;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-16 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-14 17:55 [PATCH 2/3] preferred form for passing a size to memory allocation routines anish
2011-05-15 9:37 ` Harry Wei
2011-05-16 15:49 ` [PATCH 2/3] preferred form for passing a size to memory allocation routines[staging sm7xx] anish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox