The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: linux-kernel@vger.kernel.org, Thomas Renninger <trenn@suse.de>,
	Jean Pihet <j-pihet@ti.com>,
	linux-omap@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] perf: export power_start and power_end tracepoints
Date: Mon, 16 May 2011 11:23:09 +0200	[thread overview]
Message-ID: <20110516092309.GD12325@elte.hu> (raw)
In-Reply-To: <BANLkTikkd9bNRLF1iDAz9Jwrnon3A=j44g@mail.gmail.com>


* Jean Pihet <jean.pihet@newoldbits.com> wrote:

> Adding l-o and linux-pm MLs. The original post is at
> http://www.spinics.net/lists/kernel/msg1186554.html
> 
> On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * jean.pihet@newoldbits.com <jean.pihet@newoldbits.com> wrote:
> >
> >> From: Jean Pihet <j-pihet@ti.com>
> >>
> >> If used in a module both tracepoints need to be exported by the
> >> kernel.
> >
> > but it's not used by any module in the kernel AFAICS, so why is this needed?
> Not currently, that is why the error went unnoticed. I think it is
> better to fix it now than later.
> 
> I am working on a plan to clean-up and isolate the OMAP PM code from
> the core code and to provide the PM functionality as a module. This
> effort is part of the 'remove the crazy ARM churn' from the kernel.

Feel free to keep this patch with those modifications/cleanups:

Acked-by: Ingo Molnar <mingo@elte.hu>

but please make sure you push it together, i.e. never export something 
(knowingly) without having in-tree use for it.

Thanks,

	Ingo

  reply	other threads:[~2011-05-16  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 14:43 [PATCH] perf: export power_start and power_end tracepoints jean.pihet
2011-05-13 14:48 ` Ingo Molnar
2011-05-13 15:09   ` Jean Pihet
2011-05-16  9:23     ` Ingo Molnar [this message]
2011-05-16  9:45       ` Pihet-XID, Jean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516092309.GD12325@elte.hu \
    --to=mingo@elte.hu \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox