From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Asit K Mallick <asit.k.mallick@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v2 0/4] Enable SMEP CPU Feature
Date: Tue, 17 May 2011 13:50:41 +0200 [thread overview]
Message-ID: <20110517115041.GF13475@elte.hu> (raw)
In-Reply-To: <4DD2605A.90506@redhat.com>
* Avi Kivity <avi@redhat.com> wrote:
> On 05/17/2011 02:44 PM, Avi Kivity wrote:
> >On 05/17/2011 02:38 PM, Ingo Molnar wrote:
> >>>
> >>> Depends if the guest uses a read-modify-write pattern or not.
> >>We could do it
> >>> transparently in kvm.ko, since the real cr4 need not
> >>corresponds to the guest
> >>> notion (for example, we often set cr0.wp or cr0.ts even
> >>though the guest
> >>> wants them clear).
> >>
> >>Oh, being transparent is a nice touch when it comes to security measures
> >>(catching attackers who think there's no SMEP and such) - but
> >>that would need
> >>KVM support and a new ioctl to configure it, right?
> >
> >Yes.
> >
>
> btw, KVM support is required anyway, you can't set random bits in
> cr4 (from either the guest or host userspace) - kvm needs to
> understand them.
Sure, that is the whole premise of this discussion.
I meant to say:
"but that would need KVM ABI support via a new ioctl to configure it, right?"
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-17 11:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:34 [PATCH v2 0/4] Enable SMEP CPU Feature Fenghua Yu
2011-05-16 21:34 ` [PATCH v2 1/4] x86, cpu: Add CPU flags for SMEP Fenghua Yu
2011-05-17 1:56 ` H. Peter Anvin
2011-05-16 21:34 ` [PATCH v2 2/4] x86, cpu: Add SMEP CPU feature in CR4 Fenghua Yu
2011-05-16 21:34 ` [PATCH v2 3/4] x86, head_32/64.S: Enable SMEP Fenghua Yu
2011-05-17 2:10 ` Matthew Garrett
2011-05-17 23:08 ` Yu, Fenghua
2011-05-17 23:12 ` H. Peter Anvin
2011-05-18 2:57 ` Yu, Fenghua
2011-05-16 21:34 ` [PATCH v2 4/4] x86/kernel/common.c: Disable SMEP by kernel option nosmep Fenghua Yu
2011-05-16 22:01 ` Thomas Gleixner
2011-05-16 21:52 ` [PATCH v2 0/4] Enable SMEP CPU Feature H. Peter Anvin
2011-05-17 7:05 ` Ingo Molnar
2011-05-17 9:15 ` Avi Kivity
2011-05-17 9:29 ` Ingo Molnar
2011-05-17 9:32 ` Avi Kivity
2011-05-17 10:46 ` Ingo Molnar
2011-05-17 11:34 ` Avi Kivity
2011-05-17 11:38 ` Ingo Molnar
2011-05-17 11:44 ` Avi Kivity
2011-05-17 11:47 ` Avi Kivity
2011-05-17 11:49 ` Pekka Enberg
2011-05-17 11:50 ` Ingo Molnar [this message]
2011-05-19 6:10 ` Tian, Kevin
2011-05-19 6:41 ` Shan, Haitao
2011-05-20 8:21 ` Ingo Molnar
2011-05-17 7:03 ` Ingo Molnar
2011-05-17 9:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517115041.GF13475@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=asit.k.mallick@intel.com \
--cc=avi@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox