The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"steiner@sgi.com" <steiner@sgi.com>,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gorcunov@openvz.org" <gorcunov@openvz.org>
Subject: Re: [patch 1/5] x84_64, apic: Use probe routines to simplify apic selection
Date: Tue, 17 May 2011 14:28:36 +0200	[thread overview]
Message-ID: <20110517122836.GA14758@elte.hu> (raw)
In-Reply-To: <1305589908.13584.3.camel@sbsiddha-MOBL3.sc.intel.com>


* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> On Mon, 2011-05-16 at 01:08 -0700, Ingo Molnar wrote:
> > Ok, looks like a step forward in the right direction.
> > 
> > Wouldnt it be more self-contained if the probe function returned an apic driver 
> > pointer?
> > 
> > We could add an __apicdriver section trick to 'know' about all APIC probing 
> > functions - and we'd call them one by one and use the first one that returns a 
> > non-NULL result.
> > 
> > Then we'd have the generic fallback APIC drivers as well - not marked 
> > __apicdriver but used by the probe function directly.
> > 
> > Or we could have them as __apicdriver as well, but then the .o link ordering 
> > matters to probing order.
> > 
> 
> So how does something like the appended look? There are multiple apic
> driver routines and apic name string that is being looked at by the
> generic code. So I exported the struct apic * using the section trick.
> 
> Untested for now. If you are ok, then I will post with a better
> changelog.

Yeah, this looks very nice to me.

Thanks,

	Ingo

  reply	other threads:[~2011-05-17 12:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 18:04 [patch 0/5] x2apic cluster optimization patches Suresh Siddha
2011-05-13 18:04 ` [patch 1/5] x84_64, apic: Use probe routines to simplify apic selection Suresh Siddha
2011-05-16  8:08   ` Ingo Molnar
2011-05-16  8:45     ` Cyrill Gorcunov
2011-05-16  9:03       ` Ingo Molnar
2011-05-16  9:48         ` Cyrill Gorcunov
2011-05-16 23:51     ` Suresh Siddha
2011-05-17 12:28       ` Ingo Molnar [this message]
2011-05-17 13:02         ` Thomas Gleixner
2011-05-19 23:54       ` Suresh Siddha
2011-05-13 18:04 ` [patch 2/5] x86, x2apic: Remove duplicate code for IPI mask routines Suresh Siddha
2011-05-13 18:04 ` [patch 3/5] x86, x2apic: Track the x2apic cluster sibling map Suresh Siddha
2011-05-13 18:04 ` [patch 4/5] x86, x2apic: Minimize IPI register writes using cluster groups Suresh Siddha
2011-05-13 18:04 ` [patch 5/5] x86, x2apic: Move the common bits to x2apic.h Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110517122836.GA14758@elte.hu \
    --to=mingo@elte.hu \
    --cc=gorcunov@openvz.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox