From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755715Ab1ERP0S (ORCPT ); Wed, 18 May 2011 11:26:18 -0400 Received: from out4.smtp.messagingengine.com ([66.111.4.28]:59753 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467Ab1ERP0R (ORCPT ); Wed, 18 May 2011 11:26:17 -0400 X-Sasl-enc: dj4zWP3nrX6xAUP2YYlsxFYn3Ernw3H/QWloMS0qVkpK 1305732376 Date: Wed, 18 May 2011 08:24:28 -0700 From: Greg KH To: Herton Ronaldo Krzesinski Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Olaf Hartmann Subject: Re: [RFC/RFT PATCH] Staging: et131x: add suspend/resume support Message-ID: <20110518152428.GA8106@kroah.com> References: <1305724667-2980-1-git-send-email-herton.krzesinski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305724667-2980-1-git-send-email-herton.krzesinski@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2011 at 10:17:47AM -0300, Herton Ronaldo Krzesinski wrote: > Signed-off-by: Herton Ronaldo Krzesinski I think we need a bit more comments here. Like have you tested this to verify that it works? Anything else? thanks, greg k-h