From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752900Ab1ERUA3 (ORCPT ); Wed, 18 May 2011 16:00:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43153 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439Ab1ERUA1 (ORCPT ); Wed, 18 May 2011 16:00:27 -0400 Date: Wed, 18 May 2011 12:54:49 -0700 From: Greg KH To: Grant Likely Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , sparclinux@vger.kernel.org, Linus Torvalds , David Miller , Josip Rodin Subject: Re: [PATCH 1/2] of: fix race when matching drivers Message-ID: <20110518195449.GA28653@suse.de> References: <20110518185751.28986.69446.stgit@ponder> <20110518192100.28986.94335.stgit@ponder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110518192100.28986.94335.stgit@ponder> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2011 at 01:21:00PM -0600, Grant Likely wrote: > From: Milton Miller > > If two drivers are probing devices at the same time, both will write > their match table result to the dev->of_match cache at the same time. > > Only write the result if the device matches. > > In a thread titled "SBus devices sometimes detected, sometimes not", > Meelis reported his SBus hme was not detected about 50% of the time. > >From the debug suggested by Grant it was obvious another driver matched > some devices between the call to match the hme and the hme discovery > failling. > > Reported-by: Meelis Roos > Signed-off-by: Milton Miller > [grant.likely: modified to only call of_match_device() once] > Signed-off-by: Grant Likely Acked-by: Greg Kroah-Hartman