public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]  x86: Removing unnecessary check in detect_ht
Date: Wed, 18 May 2011 23:07:54 +0200	[thread overview]
Message-ID: <20110518210754.GA28476@elte.hu> (raw)
In-Reply-To: <1F668163772FA946975B9466A9DFF729B64C@ORSMSX101.amr.corp.intel.com>


* Rao, Nikhil <nikhil.rao@intel.com> wrote:

> This patch removes a check that prevents correct CPU topology setup
> when cpuid extensions for topology enumeration are not supported and
> the number of processors reported to the OS is smaller than 
> smp_num_siblings

What bad effect was observed, exactly? An annoying warning in the bootlog and 
incorrect scheduler domain setup (SMP instead of SMT) - or something else as 
well?

Thanks,

	Ingo

  reply	other threads:[~2011-05-18 21:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <43F901BD926A4E43B106BF17856F0755018E1CF482@orsmsx508.amr.corp.intel.com>
     [not found] ` <4FF5AC937153B0459463C1A88EB478F2010DFD3D3F@orsmsx505.amr.corp.intel.com>
     [not found]   ` <43F901BD926A4E43B106BF17856F0755018E1CF69D@orsmsx508.amr.corp.intel.com>
     [not found]     ` <1305048201.2736.17.camel@sbsiddha-MOBL3.sc.intel.com>
     [not found]       ` <1F668163772FA946975B9466A9DFF729B5E5@ORSMSX101.amr.corp.intel.com>
2011-05-18 21:01         ` [PATCH] x86: Removing unnecessary check in detect_ht Rao, Nikhil
2011-05-18 21:07           ` Ingo Molnar [this message]
2011-05-18 21:13             ` Rao, Nikhil
2011-05-18 21:23               ` Ingo Molnar
2011-05-19  2:40                 ` Rao, Nikhil
2011-05-19 18:09                   ` Ingo Molnar
2011-05-19 23:03                     ` Rao, Nikhil
2011-05-20 11:46                       ` Ingo Molnar
2011-05-25 17:18                         ` Nikhil P Rao
2011-05-25 21:34                           ` [tip:x86/urgent] x86: Remove unnecessary check in detect_ht() tip-bot for Nikhil P Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518210754.GA28476@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikhil.rao@intel.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox