From: Greg KH <greg@kroah.com>
To: anish <anish198519851985@gmail.com>
Cc: teddy.wang@siliconmotion.com.cn, linux-kernel@vger.kernel.org,
harryxiyou@gmail.com
Subject: Re: [patch 2/3] Staging: sm7xx: preferred form for passing a size to memory allocation routines
Date: Wed, 18 May 2011 14:17:05 -0700 [thread overview]
Message-ID: <20110518211705.GA13555@kroah.com> (raw)
In-Reply-To: <1305738728.1881.84.camel@anish-desktop>
On Wed, May 18, 2011 at 10:42:08PM +0530, anish wrote:
> The preferred form for passing a size of a struct is the following:
> p = kmalloc(sizeof(*p), ...);
> Please refer Documentation/Codingstyle chapter 14
>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> Acked-by: Harry Wei <harryxiyou@gmail.com>
What's with the extra spaces at the beginning of the lines?
And I never got patch 1/3 in my inbox.
You also need to put your full name in the "From:" line, like you did
for the signed-off-by: line.
So, care to try again?
thanks,
greg k-h
next prev parent reply other threads:[~2011-05-18 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 17:12 [patch 2/3] Staging: sm7xx: preferred form for passing a size to memory allocation routines anish
2011-05-18 21:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 15:28 anish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518211705.GA13555@kroah.com \
--to=greg@kroah.com \
--cc=anish198519851985@gmail.com \
--cc=harryxiyou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox