From: Bill Fink <billfink@mindspring.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Decotigny <decot@google.com>,
"David S. Miller" <davem@davemloft.net>,
Joe Perches <joe@perches.com>, Szymon Janc <szymon@janc.net.pl>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-net-upstream@google.com
Subject: Re: [PATCH 1/2] forcedeth: make module parameters readable in /sys/module
Date: Wed, 18 May 2011 23:09:18 -0400 [thread overview]
Message-ID: <20110518230918.5c03ba68.billfink@mindspring.com> (raw)
In-Reply-To: <20110518150346.508d6406@nehalam>
On Wed, 18 May 2011, Stephen Hemminger wrote:
> On Wed, 18 May 2011 14:09:59 -0700
> David Decotigny <decot@google.com> wrote:
>
> > This change allows to publish the values of the module parameters in
> > /sys/module.
>
> Although this makes more info for developer, it also means more
> stuff in sysfs taking more memory and not providing any real value
> that can't be found by looking at the /etc/modprobe.d for any parameters
> user might have set.
As a user, I find having the module parameter info in
/sys/module/driver/parameters/* extremely useful at times.
In tracking down weird problems I can for example do:
grep . /sys/module/driver/parameters/*
to get a snapshot of module parameters. I can then compare
this with other similar systems to see if there are any
differences of note that might be significant (anything
from differences due to kernel versions to just forgetting
some change I made).
I don't see that it's really much extra significant overhead
on the system either.
-Bill
prev parent reply other threads:[~2011-05-19 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 21:09 [PATCH 1/2] forcedeth: make module parameters readable in /sys/module David Decotigny
2011-05-18 21:10 ` [PATCH 2/2] forcedeth: allow to silence tx_timeout debug messages David Decotigny
2011-05-18 21:16 ` David Miller
2011-05-18 21:43 ` David Decotigny
2011-05-18 22:01 ` David Miller
2011-05-18 22:03 ` [PATCH 1/2] forcedeth: make module parameters readable in /sys/module Stephen Hemminger
2011-05-18 23:21 ` David Decotigny
2011-05-19 3:09 ` Bill Fink [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518230918.5c03ba68.billfink@mindspring.com \
--to=billfink@mindspring.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=joe@perches.com \
--cc=kernel-net-upstream@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox